dear release people, I have found a stupid bug in my package gtkmorph: when displaying a warning, the string is free'd twice, and the program crashes. This happens seldom, so I did not note this before. I have uploaded xmorph 20050408b that was happily compiled bu buildds. The change to the source is represented by the diff in attachment: I cleaned up the alloc/free in the subroutine that shows the above warning. If if you have time, and if it is considered OK release-wise, would you please move gtkmorph gtkmorph-example libmorph libmorph-dev xmorph from unstable to testing? thanks a. -- Andrea Mennucc "Ukn ow,Ifina llyfixe dmysp acebar.ohwh atthef"
diff -ur tmp/xmorph-20050408/debian/changelog xmorph-current/debian/changelog
--- tmp/xmorph-20050408/debian/changelog 2005-04-09 23:41:15.000000000 +0200
+++ xmorph-current/debian/changelog 2005-05-27 10:26:28.733657816 +0200
@@ -1,3 +1,9 @@
+xmorph (1:20050408-b) unstable; urgency=low
+
+ * corrected crash when making movies, due to double free in movies.c
+
+ -- A Mennucc1 <mennucc1@debian.org> Fri, 27 May 2005 10:26:25 +0200
+
xmorph (1:20050408) unstable; urgency=low
* save_image chooses the type from extension of image file name
Only in xmorph-current/debian: changelog~
diff -ur tmp/xmorph-20050408/gtkmorph/movies.c xmorph-current/gtkmorph/movies.c
--- tmp/xmorph-20050408/gtkmorph/movies.c 2005-04-09 12:20:04.000000000 +0200
+++ xmorph-current/gtkmorph/movies.c 2005-05-27 10:28:14.335603880 +0200
@@ -321,15 +321,22 @@
struct stat buf;
for(ima=0; ima < tot; ima++) {
if (0== stat (name[ima],&buf)) {
- err=g_strdup_printf("%s\n %s ",err,name[ima]);
+ {
+ gchar * err2=g_strdup_printf("%s\n %s ",err,name[ima]);
+ g_free(err);
+ err=err2;
+ }
//perror(name[ima]);
}
}
if( strlen(err) > 0) {
- err=g_strdup_printf("the following files already exist:\n%s",err);
+ {
+ gchar * err2=g_strdup_printf("the following files already exist:\n%s",err);
+ g_free(err);
+ err=err2;
+ }
show_error(err);
- g_free(err);
for(ima=0; ima < tot; ima++)
g_free(name[ima]);
g_free(err);
Only in xmorph-current/gtkmorph: movies.c~
Attachment:
signature.asc
Description: Digital signature