Re: Bug#308290: libgphoto2-2: fails to import avis from Canon IXUS IIs
On Tue, May 10, 2005 at 01:00:53AM -0700, Steve Langasek wrote:
> On Tue, May 10, 2005 at 09:27:52AM +0200, Frederic Peters wrote:
> > Adalbert Dawid wrote:
> > > Package: libgphoto2-2
> > > Version: 2.1.5-5.0
> > > Followup-For: Bug #308290
>
> > > Indeed, after installing the three debs everything works fine again!
> > > (Would be great if this bug could be eliminated before the Sarge release...)
>
> > Aurelien, this is another camera that works with MAX_READ_WRITE set at
> > 4KB but not at 16KB. This value really looks hardcoded, I can't find
> > how libgphoto2 could fallback to a working value. Is there a way ?
>
> > Would you mind going back to 4KB blocks so we can hope for a working
> > libgphoto2/libusb combination in Sarge ?
>
> > Release team, if we agree on that change, would you be ok with an
> > upload to sarge ?
>
> It sounds ok to upload, but I make no promises about it getting in before
> seeing the code. :)
I have just uploaded a new version to testing-proposed-update. Please
find the changes between the current version in Sarge and this new one
below.
Bye,
Aurelien
diff -u libusb-0.1.10a/linux.c libusb-0.1.10a/linux.c
--- libusb-0.1.10a/linux.c
+++ libusb-0.1.10a/linux.c
@@ -132,7 +132,7 @@
* Linux usbfs has a limit of 16KB for the URB interface. We use this now
* to get better performance for USB 2.0 devices.
*/
-#define MAX_READ_WRITE (16 * 1024)
+#define MAX_READ_WRITE (4 * 1024)
int usb_control_msg(usb_dev_handle *dev, int requesttype, int request,
int value, int index, char *bytes, int size, int timeout)
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian GNU/Linux developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
Reply to: