[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

gtimer 1.1.6-4



This release fixes #309937, an important bug that *might* be on the
borderline of grave (there's some user data loss, or at least something
that could be taken that way).  I *fully* understand if you feel this is
just too late for this sort of fix; alas, it was only found on Friday.

I thought I'd send mail just in case it might be able to sneak in, though.
Please feel free to ignore this message if you don't want to spend any
time even thinking about it.

Here is the complete difference between 1.1.6-3 and 1.1.6-4 (sorry about
the diff to a diff; the package was using dbs before I took it over).
Regenerating the dbs diff also caused some other meaningless differences
in the file paths and times in the diff headers that I've omitted.

--- debian/changelog   (revision 70)
+++ debian/changelog   (revision 71)
@@ -1,3 +1,12 @@
+gtimer (1.1.6-4) unstable; urgency=medium
+
+  * Revert and Resume now only revert times on the timers that were
+    running, rather than all timers that had time for that day.  Fixes a
+    bug introduced in the last release.  Thanks to Jamm!n Wheeler for the
+    report.  (Closes: #309937)
+
+ -- Russ Allbery <rra@stanford.edu>  Fri, 20 May 2005 10:05:56 -0700
+
 gtimer (1.1.6-3) unstable; urgency=low
 
   * New maintainer.  (Closes: #288156)

--- debian/patches/24_282052-idlefixes.patch   (revision 70)
+++ debian/patches/24_282052-idlefixes.patch   (revision 71)
@@ -19,19 +19,25 @@
  
    /* reset icon */
    gdk_window_set_icon ( GTK_WIDGET ( main_window )->window,
-@@ -2620,7 +2625,8 @@
+@@ -2620,7 +2625,14 @@
        /* we've been idle too long. mark time, save to file, then popup window */
        update_tasks ();
        save_all ();
 -      taskMarkAll ();
-+      /* rra 2005-04-18 - pass timing offset into taskMarkAll */
-+      taskMarkAll ( idle );
++      /* rra 2005-04-18 - pass offset into taskMark for running timers */
++      for ( loop = 0; loop < num_tasks; loop++ ) {
++        if ( tasks[loop]->timer_on ) {
++          taskMark ( tasks[loop]->task, idle );
++        } else {
++          taskMark ( tasks[loop]->task, 0 );
++        }
++      }
        time ( &now );
        now -= idle;
        tm = localtime ( &now );

-- 
Russ Allbery (rra@stanford.edu)             <http://www.eyrie.org/~eagle/>



Reply to: