Hello,
I uploaded a new upstream (oh well, upstream is me) of cpufreqd. It
fixes 3 memomry leaks and a segfault, changes are really trivial (diff
is included below).
There are no bugs in the BTS regarding those issues.
One of the 3 leaks (even if never reported before) can become pretty
annoying as it happens in a function that is called each time cpufreqd
applies a new profile.
The segfault is caused by a wrong long_options[] (getopt) setup.
Here's the difference between 1.2.2 and 1.2.3 for the code part only,
debian packaging is identical:
diff -Nru cpufreqd-1.2.2/main.c cpufreqd-1.2.3/main.c
--- cpufreqd-1.2.2/main.c 2004-10-25 13:04:27.000000000 +0200
+++ cpufreqd-1.2.3/main.c 2005-05-14 14:33:52.000000000 +0200
@@ -153,6 +153,7 @@
/* free configuration */
free_config(configuration);
+ free(configuration);
/* TODO: this call to close log shound not sit here... */
closelog();
@@ -423,6 +424,7 @@
sleep(configuration->poll_interval);
} /* end loop */
+ free(_system);
return 0;
}
@@ -506,7 +508,7 @@
*/
int set_policy(profile *prof) {
FILE *fp;
- char *path = (char *)malloc(256);
+ char path[256];
if (!prof)
return -1;
@@ -852,7 +854,7 @@
{ "version", 0, 0, 'v' },
{ "file", 1, 0, 'f' },
{ "no-daemon", 0, 0, 'D' },
- { "verbosity", 0, 0, 'V' },
+ { "verbosity", 1, 0, 'V' },
{ 0, 0, 0, 0 },
};
int ch,option_index = 0;
Thanks and sorry for the extra-work I caused.
--
mattia
:wq!
Attachment:
signature.asc
Description: Digital signature