Re: please approve mgetty 1.1.33-2
* Frank Lichtenheld (djpig@debian.org) [050513 22:05]:
> On Fri, May 13, 2005 at 08:42:51AM +0200, Andreas Barth wrote:
> > please approve this new mgetty upload for sarge. It fixes two nasty
> > issues (with low-risk changes):
> > * Previously, only root could set fax jobs to specific users - now also
> > lp and daemon, which is necessary for integrating into a printing
> > system
> hmm, that change looks very hackish to me. Wouldn't it be better
> to resolve the names of the users to uids instead of just assuming
> the default values?
I fully agree that the current patch won't stay forever. However, in
considering which route to take, I took the hard-coded values one for
sarge for the following reasons:
* I need only to touch a single line, and it's very easy to see that
this is done without a new bug. So, the impact is much lower (this is
the main reason for me).
* The uids are not going to change for sarge anyway.
The right long-term solution is - IMHO - to have a configuration value
that defaults to "root lp daemon", and where anyone who is mentioned
there is excepted (and also allow groups, e.g. with "%adm". However,
_that_ change is much more invasive, and IMHO post-freeze.
If you disagree with this solution, please feel free to tell me so, and
I'll finalize and upload the other patch.
Cheers,
Andi
--
http://home.arcor.de/andreas-barth/
PGP 1024/89FB5CE5 DC F1 85 6D A6 45 9C 0F 3B BE F1 D0 C5 D1 D9 0C
Reply to: