Kimmo Jukarainen wrote: > Joey Hess wrote: > > I didn't check to see if NO_ZPIPE gets defined; if it does the blocks of > > code above won't be built in. And yes, I noticed the same code already > > exists in Xm-2.1/Xpm.c, also in #ifndef NO_ZPIPE. > > Actually, Xm-2.1/Xpm.c is no longer used, it was replaced with Xpm*.c > in your -11.2 upload. But yes, the same problem seems to be present > in the splitted up files too (XpmWrFFrI.c and XpmRdFToI.c). > > There seems to be fix for this in Xorg CVS (dated Dec 11 2004). I'll > backport those changes for both Xm/ and Xm-2.1/ tomorrow if no-one > else hasn't done it by then. > > > +#ifndef NO_ZPIPE > > +/* FILE *s_popen(char *cmd, const char *type); */ > > +#else > > +# define s_popen popen > > +#endif > > The above mentioned fix seems to get rid of this too. Does it also deal with the redirection and quoting issues in parameters to s_popen? > > I think this is broken; data_size is used undefined AFAICS: > > > > @@ -7027,6 +7289,7 @@ > > static void > > CreateExtensions( > > char **dataptr, > > + unsigned int data_size, > > unsigned int offset, > > _LtXpmExtension *ext, > > unsigned int num, > > Erm. It's function parameter, not a local variable, so I don't see the > problem here. (And this code is up-to-date with current xorg cvs). Whoops, that style trips me up every time. Thanks for your work on lesstif. -- see shy jo
Attachment:
signature.asc
Description: Digital signature