[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: please migrate pppoeconf 1.3 to testing



On Fri, Mar 18, 2005 at 12:19:30PM +0100, Eduard Bloch wrote:
> please force pppoeconf 1.3 into testing, it solves to nasty problems:
> 
>  - #298223: pppoeconf: setting up ppp_on_boot is depercated
>   (init script from ppp spews lot of warnings)
>  - #296778: wrong permissions of dsl-provider
>   (follows the current relaxed policy for permissions in /etc/ppp)

'echo -e' is a bashism, so this will break if /bin/sh is e.g. dash:

+if ! grep -q "dsl-provider" $INTFILE ; then
+   echo -e 'iface dsl-provider inet ppp\n\tprovider dsl-provider\n' >> $INTFILE
+fi

I'd suggest using printf instead.

Also, could you add a versioned dependency on sed (>= 3.95) or something
like that for 'sed -i'? woody's version doesn't have that.

Thanks,

-- 
Colin Watson                                       [cjwatson@debian.org]



Reply to: