Re: possible update for bsdmainutils
On Mon, Nov 01, 2004 at 03:09:00PM +0100, Frank Lichtenheld wrote:
> On Wed, Oct 27, 2004 at 01:34:29PM -0500, Graham Wilson wrote:
> > There is an outstanding bug (#254075) for bsdmainutils, which describes
> > a case where calendar(1) claims a file contains an invalid multibyte
> > sequence, even when it doesn't, on alpha (and maybe other platforms
> > where sizeof(int) != sizeof(size_t)).
> [..]
> > Can this change be pushed to testing if I upload the package to
> > unstable?
>
> Yes.
Well, what I meant was "Will this change be pushed to testing." Anyhow,
I've uploaded the package to unstable, since the aforementioned bug
essentially make calendar(1) useless where sizeof(size_t) !=
sizeof(int).
Release managers, can you review the following changes, and push
bsdmainutils to testing if appropriate?
Index: usr.bin/calendar/wcslib.c
===================================================================
--- usr.bin/calendar/wcslib.c (.../6) (revision 124)
+++ usr.bin/calendar/wcslib.c (.../7) (revision 124)
@@ -99,7 +99,7 @@
utf8towcs (wchar_t *out, char *in, size_t n)
{
char *ip = in, *op = (char *) out;
- int ibl = strlen(in), obl = n * sizeof(wchar_t);
+ size_t ibl = strlen(in), obl = n * sizeof(wchar_t);
static iconv_t cd = (iconv_t) -1;
int r;
Index: debian/changelog
===================================================================
--- debian/changelog (.../6) (revision 124)
+++ debian/changelog (.../7) (revision 124)
@@ -1,3 +1,11 @@
+bsdmainutils (6.0.17) unstable; urgency=medium
+
+ * Use size_t (instead of int) when calling iconv(3): using int on alpha
+ caused iconv to read past the end of the buffer, and return EILSEQ.
+ (closes: #254075)
+
+ -- Graham Wilson <graham@debian.org> Wed, 27 Oct 2004 18:31:03 +0000
+
bsdmainutils (6.0.16) unstable; urgency=high
* Correct the listed charset in a few .po files, and a mis-encoded character
--
gram
Reply to: