Hi Javier, Thanks for taking up the challenge of NMUing this package. On Sat, Oct 23, 2004 at 02:06:42AM +0200, Javier Fernández-Sanguino Peña wrote: > I have dedicated some time to start preparing a modutils NMU fixing both > the current RC bugs and lot of longstanding bugs currently present and > really easy to fix. Attached is the resulting patch (currently untested, > I want to keep working on adding some more fixes). I don't know if I'll > make it in time for having it sufficiently tested so that it can go into > the release..... > Please tell me if you approve of this patch, and, if not, the reasons you > reject it. I would really like to help you weed bugs out of this package. > Release team, I would also appreciate some action on this, since it seems > that some users (PPPOE users using d-i and some users upgrading from older > releases) will need this new version in order to install/use their Debian > system properly. > Also notice that there is a new upstream, and it has some bug fixes that > might be appropiate to include too, if everyone is OK with it, I could NMU > based on the latest upstream release. I'm very concerned by the number of changes included in this NMU, not even counting the new upstream version. The release-critical bugs *must* be resolved before release, and attempts to fix other, unrelated bugs in the same upload stand a very good chance of introducing new RC bugs and keeping the package out of testing. Especially since you say this patch is untested, it also makes it more questionable to approve pushing such a changeset past the freeze without giving it the full 10-day waiting period. Please consider limiting your NMU changeset to those changes required for fixing the RC bugs. -- Steve Langasek postmodern programmer > diff -Nru modutils-2.4.26.old/debian/changelog modutils-2.4.26/debian/changelog > --- modutils-2.4.26.old/debian/changelog 2004-09-25 18:47:08.000000000 +0200 > +++ modutils-2.4.26/debian/changelog 2004-10-22 16:59:53.000000000 +0200 > @@ -1,3 +1,58 @@ > +modutils (2.4.26-1.1) unstable; urgency=high > + > + * NMU. Urgency set to 'high' as this version fixes a number of RC and > + longstanding bugs that we probably want to have fixed for sarge. > + [debian/conf/aliases] > + - Added missing aliases to modutils based on patches from other vendors > + (Fedora Core 2 and Mandrake 10) and from the modules defined in > + module-init-tools for kernels 2.6 and above. These include aliases for: > + - pppoe (Closes: #262941, #263224, #272581) > + - ipsec (Closes: #203578 > + - ide-prob-mod incantation aliases due to module name changes > + done in 2.4.22 (Closes: #228031, #210516) > + - psmouse (Closes: #230020) > + - zftape (Closes: #70557) > + - raw (Closes: #228688) > + - cpuid and msr (Closes: #243681) > + - ppp_mppe (Closes: #173938) > + [util/alias.h] > + - Included RedHat's patch that modifies the behaviour of > + modprobe for some systems that do not provide a floppy disk > + (like s390, powerpc...) > + - Updated some aliases definitions. > + [debian/update-modules] > + - Apply patch to avoid loading configuration files > + suffixed with '.orig' as per Joey's request (Closes: #54967) > + - Avoid also loading RCS files (,v suffix) as requested by Mark Histed > + (Closes: #118647) > + - Do not use depfile statements if commented in modules.conf > + (Closes: #69754) > + - Abort with exit code 3 if configuration files are not automatically > + generated (Closes: #166531) > + - Add a check in addfile() so that dangling symlinks are avoided, the code > + should not get there (because of the previous -f check) but this should > + avoid the issue observed by users which breaks upgrades (Closes: #220382) > + - More verbose message when encoutering errors executing scripts under > + /etc/modutils as it has been reported by a user that there might be > + files with incorrect execute permissions set (Closes: #253508) > + - Removed trailing " when setting the HEADER (Closes: #173746) > + [debian/update-modules.8] > + - Reworded sentence for clarity as suggested by Robert Millan > + (Closes: #140776) > + - Added new suffixes that will not be loaded (.orig and ,v) > + - Document current exit codes (0=no error, 1=error, 2=not root, > + 3=not autogenerated) > + [debian/control] > + - Mention module-init-tools (for 2.6 users) in the package description > + (Closes: #267112) > + [ Translations ] > + - Included the following manpage translations: > + * pt_BR provided by Philippe Gaspar (Closes: #194502) > + * es provided by Ruben Porras (Closes: #206205) > + * fr provided by Julien Louis (Closes: #165098, #166713) > + > + -- Javier Fernandez-Sanguino Pen~a <jfs@computer.org> Fri, 22 Oct 2004 16:37:54 +0200 > + > modutils (2.4.26-1) unstable; urgency=low > > * New upstream release.
Attachment:
signature.asc
Description: Digital signature