[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#1040498: Should we consider the transition ready (Was: Bug#1040498: transition: r-bioc-biocgenerics)



Hi Andreas

On Wed, 16 Aug 2023 at 11:24, Andreas Tille <andreas@an3as.eu> wrote:
> Am Tue, Aug 01, 2023 at 01:06:41PM +0000 schrieb Graham Inggs:
> > At least the following packages are failing their own autopkgtests in
> > unstable (list not complete):
> > r-bioc-cummerbund
> > r-bioc-decoupler
> > r-bioc-monocle
> > r-bioc-scran
> > r-bioc-singler
>
> Most of those packages have autopkgtests marked as
>    Failed (not a regression)
> Am I correct that we do not need to take any action regarding the
> transition?

Well, it means those autopkgtests already regressed in testing, but
they do not block migration.
Now that r-bioc-biocgenerics has migrated, you can see that at least
r-bioc-cummerbund, r-bioc-scran and r-bioc-singler are still blocked
by other packages which need attention.

> > r-bioc-dupradar has regressed from passing to neutral, apparently due
> > to the use of 'skip-not-installable'.  Please don't use this
> > restriction on all the autopkgtests in a package, otherwise there are
> > no tests which are not superficial, and regressions can migrate to
> > testing.
>
> Could you please be more verbose about this hint (may be suggesting a
> patch that implements your suggestion since I'm afraid I do not
> understand this correctly)

--- a/debian/tests/autopkgtest-pkg-r.conf
+++ b/debian/tests/autopkgtest-pkg-r.conf
@@ -2,4 +2,3 @@
               r-cran-knitr, \
               r-cran-rmarkdown, \
               r-bioc-annotationhub
-extra_restrictions=skip-not-installable

In general, skip-not-installable is no good as it does not catch when
packages are non-installable, and during that time, it can hide other
regressions and allow them to migrate.  It may have some special use
cases; e.g. a test depending on a package that is only available in
unstable (virtualbox or openjdk-8), but skip-not-installable should
not be applied to a package's only autopkgtest, or all of them, only
the one that actually requires it.

On Fri, 18 Aug 2023 at 10:40, Andreas Tille <tille@debian.org> wrote:
> I've fixed r-bioc-decoupler manually to remove this blocker quickly
> (instead of working around invalid version specifications by detecting
> these in dh-r)

Thanks!  elbrus marked r-bioc-decoupler urgent, and rather than being
blocked by the autopkgtest regression of r-bioc-metagenomeseq, I
removed 1.40.0-1 from testing (previously removed on 2023-07-16, but
somehow migrated again) to allow r-bioc-biocgenerics to migrate.

> Do you see any other blocker?

Besides those packages mentioned above, there are others still needing
attention.  These can be seen on the team's DDPO page [1], just search
for 'Excuse' there.

Regards
Graham


[1] https://qa.debian.org/developer.php?email=r-pkg-team%40alioth-lists.debian.net


Reply to: