[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Two other packages are now failing their debci tests on i386 (Was: Bug#1024012: [joshuaulrich/xts] Unit test failure when running on i386 (Issue #384))



Am Tue, Jan 24, 2023 at 10:12:42AM +0200 schrieb Adrian Bunk:
> > I can include this patch as well.
> 
> The Ubuntu diff followed by
> 
> if [ "$hostarch" = "i386" ] ; then
>     rm -f profbound.R
> fi
> 
> works for me.

This will definitely work.  However, I'd like to keep more of the tests and tried

diff --git a/debian/tests/run-unit-test b/debian/tests/run-unit-test
index ce1d7be..81419cc 100644
--- a/debian/tests/run-unit-test
+++ b/debian/tests/run-unit-test
@@ -44,6 +44,22 @@ fi
 # skip tests which have no saved results
 rm -f boundstest.R impsamp.R prof_newmin.R prof_spec.R
 
+hostarch=$(dpkg-architecture -qDEB_HOST_ARCH)
+# Ignore single test for i386 architecture.  This is a workaround for a strange test error that occured after r-base was compiled with -ffloat-store
+if [ "$hostarch" = "i386" ] ; then
+  sed -i '/pp <- profile(fit2,prof.lower=-0.2)/,$d' profbound.R*
+  echo '> ' >> profbound.Rsave
+fi
+


(which has some remaining trouble with the line ending in the compared
output which I'll fix later).
 
> > I can't reproduce this one in my i386 pbuilder chroot.
> 
> It fails when testing the package in unstable/testing, but passes after 
> recompiling that one with the new r-base.

So do you think I should simply re-upload?

Kind regards
   Andreas. 

-- 
http://fam-tille.de


Reply to: