[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please specify version of ade4 with same characters in phyloseq



Sounds good. I already made and pushed the change.
Best,
.....
"Joey"
Paul J. McMurdie




On Mon, Nov 29, 2021 at 11:49 AM Andreas Tille <tille@debian.org> wrote:
Hi Paul,

Am Mon, Nov 29, 2021 at 09:29:37AM -0800 schrieb Paul Joseph McMurdie:
> Andreas,
> Sure, that's no problem. As you know it might take a little while to
> percolate into the release branch, but I am happy to make the change now
> and get that process started.

Thanks a lot.  There is no need to hurry up since I've just patched for
the current version and whenever you release the next version I'll simply
drop that patch.

Thanks a lot for your cooperation

      Andreas.

> On Thu, Nov 25, 2021 at 2:02 AM Andreas Tille <andreas@an3as.eu> wrote:
>
> > Hi Paul,
> >
> > I'm just upgrading the Debian packaging of BioConductor phyloseq to
> > version 1.38.0.  In the DESCRIPTION file you are specifying
> >
> >    Imports: ade4 (>= 1.7.4)
> >
> > Ade4 authors are using a version scheme 1.7-18 (latest version) so they
> > use a '-' sign for the micro version specification.  I'm perfectly aware
> > that in R version number separators '.' and '-' are sorting equally.
> > However, this leads to sorting issues in the Debian packaging
> > dependencies.  You would do us a great favour if you simply stick to
> > the same separating characters as the authors have choosen.  In other
> > words, this patch
> >
> > diff --git a/DESCRIPTION b/DESCRIPTION
> > index 457fcc8..35b6c57 100644
> > --- a/DESCRIPTION
> > +++ b/DESCRIPTION
> > @@ -10,7 +10,7 @@ Author: Paul J. McMurdie <joey711@gmail.com>,
> >      Susan Holmes <susan@stat.stanford.edu>, with
> >      contributions from Gregory Jordan and Scott Chamberlain
> >  License: AGPL-3
> > -Imports: ade4 (>= 1.7.4), ape (>= 5.0), Biobase (>= 2.36.2),
> > +Imports: ade4 (>= 1.7-4), ape (>= 5.0), Biobase (>= 2.36.2),
> >          BiocGenerics (>= 0.22.0), biomformat (>= 1.0.0), Biostrings (>=
> >          2.40.0), cluster (>= 2.0.4), data.table (>= 1.10.4), foreach
> >          (>= 1.4.3), ggplot2 (>= 2.1.0), igraph (>= 1.0.1), methods (>=
> >
> > would safe us some extra work.
> >
> > Thanks a lot for your cooperation
> >
> >       Andreas.
> >
> >
> > --
> > http://fam-tille.de
> >

--
http://fam-tille.de

Reply to: