Re: Test suite failures in base64url
Hi,
AFAICT there is no bug in base64url. The triggered unit test
(https://github.com/cran/base64url/blob/master/tests/testthat/test_base64.R#L47)
just verifies that a base64-encoded random string "plain" decodes to
"plain" again - here both encoder and decoder are from the base64enc
(*not* base64url) package. I use this package and also the openssl
package to verify the results of my base64 implementations in the unit
tests.
After a quick look into the source of base64enc, I noticed that
base64enc doesn't convert the input/output to UTF8 which then leads to
problems in your locale.
I guess that Simon (CCed) forgot to throw in some translateCharUTF8()
and mkCharCE() calls.
Best,
Michel
2018-05-06 16:58 GMT+02:00 Dirk Eddelbuettel <edd@debian.org>:
>
> On 6 May 2018 at 16:34, Andreas Tille wrote:
> | Hi,
> |
> | I intend to package base64url for Debian. When I was running the
> | test suite I got:
> |
> | == testthat results ===========================================================
> | OK: 124 SKIPPED: 0 FAILED: 20
> | 1. Failure: comparison with base64enc (@test_base64.R#47)
> | 2. Failure: comparison with base64enc (@test_base64.R#55)
> | 3. Failure: comparison with base64enc (@test_base64.R#47)
> | 4. Failure: comparison with base64enc (@test_base64.R#55)
> | 5. Failure: comparison with base64enc (@test_base64.R#47)
> | 6. Failure: comparison with base64enc (@test_base64.R#55)
> | 7. Failure: comparison with base64enc (@test_base64.R#47)
> | 8. Failure: comparison with base64enc (@test_base64.R#55)
> | 9. Failure: comparison with base64enc (@test_base64.R#47)
> | 1. ...
> |
> | Error: testthat unit tests failed
> |
> | Is there any known issue or am I missing something?
>
> See
>
> https://cloud.r-project.org/web/checks/check_results_base64url.html
>
> which is as clean as it can get across different OSs and toolchains.
>
> Dirk
>
> --
> http://dirk.eddelbuettel.com | @eddelbuettel | edd@debian.org
Reply to: