Re: Minor dh-r bug
Hi Dirk,
On Mon, Apr 02, 2018 at 08:29:33AM -0500, Dirk Eddelbuettel wrote:
>
> 'Priority: recommended' is not picked up as it is compared to 'Recommended'
> (ie with a capital R), so packages like r-cran-cluster and r-cran-matrix,
> which used to go to /usr/lib/R/library by our convention now end up in
> /usr/lib/R/site-library like all others.
>
> I changed line 102 in R.pm from
>
> if (${desc}->{Priority} eq "Recommended") {
>
> to recognise both cases, but somehow it didn't propagate.
It would help if you could somehow provide your preliminary packaging to
test the changes without doing the migration work you probably have
done. May be you also post your actual attempt to patch R.pm.
Something like this
$ git diff
diff --git a/dh/R.pm b/dh/R.pm
index f70905d..ea62392 100644
--- a/dh/R.pm
+++ b/dh/R.pm
@@ -99,7 +99,7 @@ sub install {
# Priority: Recommended should go in /library instead of /site-library
my $libdir = "usr/lib/R/site-library";
- if ($desc->{Priority} eq "Recommended") {
+ if (lc($desc->{Priority}) eq "recommended") {
$libdir = "usr/lib/R/library";
say "I: R package with Priority: $desc->{Priority}, installing in $libdir";
}
should work.
> Could one of you please look into this?
I think its better to file a bug report. I would have tagged it with
"more info: please provide your actual usage of dh-r" to make it easier
to check.
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: