Bug#1117078: knotifications: Build-Depends on dbus-x11 (dbus-launch)

[Simon McVittie <smcv@debian.org>]

Source: knotifications
Version: 5.116.0-1
Severity: normal
User: dbus@packages.debian.org
Usertags: dbus-launch dbus-launch-for-tests

This package build-depends on dbus-x11, and seems to be invoking 
dbus-launch explicitly from inside one of its tests (although I'm not 
sure whether that code path is actually taken).

D-Bus X11 autolaunching is a poorly-understood legacy code path which 
should be avoided where possible. Instead, if possible please 
build-depend on dbus-daemon and invoke a temporary D-Bus session bus 
explicitly (which in fact is already done):

override_dh_auto_test:
	xvfb-run -a dbus-run-session dh_auto_test

This only requires a B-D on dbus-daemon <!nocheck>, which is a smaller 
dependency than dbus-x11 and contains more robust code.

If that isn't sufficient and dbus-launch is still invoked, then changes 
to the C++ test code might be necessary to be able to remove the 
dbus-x11 dependency.

(See also the mass bug filing back in 2016, 
<https://lists.debian.org/debian-devel/2016/08/msg00554.html>).

Thanks,
    smcv