[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1108512: marked as done (kde-config-sddm: Writes to /usr/share upon applying theme)

Your message dated Sun, 20 Jul 2025 07:35:11 +0000
with message-id <E1udOZj-000CIl-1c@fasolo.debian.org>
and subject line Bug#1108512: fixed in sddm-kcm 4:6.3.4-4
has caused the Debian Bug report #1108512,
regarding kde-config-sddm: Writes to /usr/share upon applying theme
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1108512: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1108512
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: kde-config-sddm
Version: 4:6.3.4-2
Severity: serious
Tags: patch
Justification: Policy 9.1
While the theme edit function has been nicely disabled (bug #1090041) so it no longer writes to /usr until (hopefully) upstream comes up with a better way to do this, upon applying a different theme the kde sddm config module will still 
write a theme.config.user file to /usr/share/sddm/themes/$theme, saving any
possible changes to the theme globally and violating FHS once more. Since the 
theme cannot be edited with the previous fix in place anyway, this file is
redundant, too. As a sidenote, this issue is what triggers bug #1107185. It is not the root cause (the kde config module writes a relative background image path to the user config, and since sddm theme debian-breeze is based on (basically: 
extends) theme breeze, sddm now looks in the wrong directory), but once the
user config is removed, that bug is fixed, or at least no longer triggered.

I have attached a patch that removes the creation of this user config file.
Obviously this will not undo any 'damage' that has already been done; maybe one 
could include a scan that removes all instances of theme.config.user below
/usr/share/sddm/themes in a post-install script or something, but I did not
bother.

Kind regards,

Jordi Bosveld


-- System Information:
Debian Release: 13.0
APT prefers testing-security
APT policy: (500, 'testing-security'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.12.33+deb13-amd64 (SMP w/24 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en_US 
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages kde-config-sddm depends on:
ii libc6 2.41-9
ii libkf6archive6 6.13.0-2
ii libkf6authcore6 6.13.0-1
ii libkf6configcore6 6.13.0-2
ii libkf6configgui6 6.13.0-2
ii libkf6coreaddons6 6.13.0-1
ii libkf6i18n6 6.13.0-1
ii libkf6kcmutilscore6 6.13.0-2
ii libkf6kcmutilsquick6 6.13.0-2
ii libkf6kiogui6 6.13.0-6
ii libkf6service-bin 6.13.0-1
ii libkf6service6 6.13.0-1
ii libkf6widgetsaddons6 6.13.0-1
ii libqt6core6t64 6.8.2+dfsg-7
ii libqt6dbus6 6.8.2+dfsg-7
ii libqt6gui6 6.8.2+dfsg-7
ii libqt6qml6 6.8.2+dfsg-7
ii libqt6widgets6 6.8.2+dfsg-7
ii libstdc++6 14.2.0-19
ii qml6-module-org-kde-kcmutils 6.13.0-2
ii qml6-module-org-kde-kirigami 6.13.0-2
ii qml6-module-org-kde-kitemmodels 6.13.0-1
ii qml6-module-org-kde-newstuff 6.13.0-1
ii qml6-module-qt5compat-graphicaleffects 6.8.2-3+b1
ii qml6-module-qtquick 6.8.2+dfsg-7
ii qml6-module-qtquick-controls 6.8.2+dfsg-7
ii qml6-module-qtquick-dialogs 6.8.2+dfsg-7
ii qml6-module-qtquick-layouts 6.8.2+dfsg-7
ii qml6-module-qtquick-window 6.8.2+dfsg-7
ii systemsettings 4:6.3.4-2

kde-config-sddm recommends no packages.

kde-config-sddm suggests no packages.

-- no debconf information
--- sddm-kcm-6.3.4.orig/src/sddmkcm.cpp
+++ sddm-kcm-6.3.4/src/sddmkcm.cpp
@@ -118,17 +118,6 @@ void SddmKcm::save()
     const QModelIndex currentThemeIndex = m_themesModel->index(m_themesModel->currentIndex());
     const QString themeConfigPath = m_themesModel->data(currentThemeIndex, ThemesModel::PathRole).toString()
         + m_themesModel->data(currentThemeIndex, ThemesModel::ConfigFileRole).toString();
-    if (!themeConfigPath.isEmpty()) {
-        args[QStringLiteral("theme.conf.user")] = QVariant(themeConfigPath + QStringLiteral(".user"));
-        const QString backgroundPath = m_themesModel->data(currentThemeIndex, ThemesModel::CurrentBackgroundRole).toString();
-        if (!backgroundPath.isEmpty()) {
-            args[QStringLiteral("theme.conf.user/General/background")] = backgroundPath;
-            args[QStringLiteral("theme.conf.user/General/type")] = QStringLiteral("image");
-        } else {
-            args[QStringLiteral("theme.conf.user/General/type")] = QStringLiteral("color");
-        }
-        args[QStringLiteral("theme.conf.user/General/showClock")] = m_themesModel->data(currentThemeIndex, ThemesModel::ShowClockRole).toBool();
-    }
     args[QStringLiteral("kde_settings.conf/Theme/Current")] = currentThemeIndex.data(ThemesModel::IdRole);
     args[QStringLiteral("kde_settings.conf/Autologin/User")] = m_data->sddmSettings()->user();
     args[QStringLiteral("kde_settings.conf/Autologin/Session")] = m_data->sddmSettings()->session();

--- End Message ---
--- Begin Message --- 
Source: sddm-kcm
Source-Version: 4:6.3.4-4
Done: Aurélien COUDERC <coucouf@debian.org>

We believe that the bug you reported is fixed in the latest version of
sddm-kcm, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1108512@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aurélien COUDERC <coucouf@debian.org> (supplier of updated sddm-kcm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 20 Jul 2025 08:26:29 +0200
Source: sddm-kcm
Architecture: source
Version: 4:6.3.4-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Aurélien COUDERC <coucouf@debian.org>
Closes: 1108512
Changes:
 sddm-kcm (4:6.3.4-4) unstable; urgency=medium
 .
   [ Aurélien COUDERC ]
   * Fix kde-config-sddm: Writes to /usr/share upon applying theme.
     (Closes: #1108512)
Checksums-Sha1:
 c6c0d3d3b10fe8adaf604c426623f61789bb4164 2715 sddm-kcm_6.3.4-4.dsc
 b1c3c24c238e3cd40ea1f55aa0c6a86e9faedf72 16932 sddm-kcm_6.3.4-4.debian.tar.xz
 3978fcc7a78de6a8a9dd192ca9a56233938ea5b6 20652 sddm-kcm_6.3.4-4_amd64.buildinfo
Checksums-Sha256:
 1d4d7461f685a71dd346139ce37cf570bd3bc1cfa9987dab8e8b65e7a8c3b8cd 2715 sddm-kcm_6.3.4-4.dsc
 d033cb06d0c955c3d460665b8a818a86502a7f6671e7b8679b4aa093d91ea9f4 16932 sddm-kcm_6.3.4-4.debian.tar.xz
 72e741ab86d154aee48acedab3f0e1843cc9b72e5d1883c1b8021fd3e6074871 20652 sddm-kcm_6.3.4-4_amd64.buildinfo
Files:
 965afcc216b602334c7863f8f37b5202 2715 kde optional sddm-kcm_6.3.4-4.dsc
 7591eef9eed84a7651408f9e09e6fc3a 16932 kde optional sddm-kcm_6.3.4-4.debian.tar.xz
 fa138639b1bbf302649ea33d8e8dbca4 20652 kde optional sddm-kcm_6.3.4-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEEIW//QAAaDgcOKDsfcaflM/KRoyQFAmh8ltETHGNvdWNvdWZA
ZGViaWFuLm9yZwAKCRBxp+Uz8pGjJOC6D/9byAZUD/Ybovfm9/gCZ2vUK2Tfxwgz
sszg40yr+Yc2PIVqZMuZKP4OVb26zBpcbPUtYkm5IOEZm/2pzW1qod/QB5p2l4na
HYQrx+gZuRXHREYsyiK6vIJ3QJNlSUSFzxWW0DPelhMExbVXzz2fuM0PEJPktGYM
WNsBp+FvM3oOHOfPMaMQAVVrfZ8xRKpnNjRqn7OkqBS+nv6tqoqSn4WAifNRg/QL
0o18M5AC0DjqNGmyMB/xLhnQhms8o8IAO/25hqTVsWWdKHV5qtZLwLmDZInLam8H
Tj+JrxQLdmvI4Obu/ANO/KBKhcMPso8/hXV3NPJiNxr+W90rlVe2CAtzeTvYIdQb
2L+HzTAKH3MHZiuCmlLGsBbFdZtdLvTbWmLB+4/TlY9MU0uifkPyiqgf8fT/3ib6
psJoaYdWOeigncCuoizyJvdXmkw57kXuZ+3DX3MNAIjhiC89PLNkJfuSa/6e7N3U
fTuuitrai5oTSWkaFnOXmJCZu2s5oe6+4o7JL5GxqVpUhiqt6p1GrdpFBQa0X078
JyAtF79RoVXQQsctPftCkrCaGfd0vUMhpvqfnMTfkQXYyCUlk4Yb0sTs9/oV1Cq4
iUeyJ/GwyqHNsky9P3DAV5B1xEwJQD4umEmPyt1VOc5q0RCX7s7PlnTCrurf0qWl
O/HIrZkICE1PAg==
=/3qH
-----END PGP SIGNATURE-----

Attachment: pgpQZXgO5zvPL.pgp
Description: PGP signature


--- End Message ---
Reply to: