[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1101514: marked as done (kio-extras: [upstream] Spurious windows while generating HTML preview in Wayland)

Your message dated Fri, 11 Apr 2025 22:09:50 +0000
with message-id <E1u3MZK-006paI-AU@fasolo.debian.org>
and subject line Bug#1101514: fixed in kio-extras 4:25.03.90-1
has caused the Debian Bug report #1101514,
regarding kio-extras: [upstream] Spurious windows while generating HTML preview in Wayland
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1101514: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1101514
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: kio-extras
Version: 4:24.12.2-2
Severity: important
Tags: patch upstream fixed-upstream X-Debbugs-Cc: jrubcop@gmail.com

Dear Maintainer,
Upstream kio-extras had a bug 500173 Spurious windows while generating HTML preview in Wayland [1] where when viewing HTML documents in a Wayland session, using Dolphin for example, kioworker would generate distracting Wayland windows from kioworker and use them to build thumbnails, removing focus from the user until thumbnails were generated.
This has been fixed upstream, but is not yet in a tagged release. The most recent upstream tagged release, v24.12.3, patches out the initial fix for this bug found in MR 412 [2] as it introduced a regression where icons generated would no longer respect the current KDE theme, however this regression was fixed in MR 415 [3] which was merged.
As it is not released yet I have included a backport to fix the issue in the meantime. This backport includes the content of the referenced MRs 412 and 415. 



Best Regards,
Jonathan Rubenstein



[1]: https://bugs.kde.org/show_bug.cgi?id=500173
[2]: https://invent.kde.org/network/kio-extras/-/merge_requests/412
[3]: https://invent.kde.org/network/kio-extras/-/merge_requests/415


-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.12.19-amd64 (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fi_FI.UTF-8, LC_CTYPE=fi_FI.UTF-8 (charmap=UTF-8), LANGUAGE=fi:en_US:en_GB 
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages kio-extras depends on:
ii  kio-extras-data              4:24.12.2-2
ii  kio6                         6.11.0-1+b1
ii  libappimage1.0abi1t64        1.0.4-5-4
ii  libc6                        2.41-6
ii  libgcc-s1                    14.2.0-19
ii  libimobiledevice-1.0-6       1.3.0+git20240701-4+b1
ii  libkdsoap-qt6-2              2.2.0+dfsg-3
ii  libkdsoapwsdiscoveryclient0  0.4.0-2
ii  libkexiv2qt6-0               24.12.3-1
ii  libkf6archive6               6.11.0-1
ii  libkf6configcore6            6.11.0-1
ii  libkf6configgui6             6.11.0-1
ii  libkf6coreaddons6            6.11.0-1
ii  libkf6dbusaddons6            6.11.0-1+b1
ii  libkf6dnssd6                 6.11.0-1
ii  libkf6i18n6                  6.11.0-1
ii  libkf6kcmutils6              6.11.0-1
ii  libkf6kcmutilscore6          6.11.0-1
ii  libkf6kiocore6               6.11.0-1+b1
ii  libkf6kiofilewidgets6        6.11.0-1+b1
ii  libkf6kiogui6                6.11.0-1+b1
ii  libkf6kiowidgets6            6.11.0-1+b1
ii  libkf6service-bin            6.11.0-1
ii  libkf6service6               6.11.0-1
ii  libkf6solid6                 6.11.0-1
ii  libkf6syntaxhighlighting6    6.11.0-1
ii  libkf6textwidgets6           6.11.0-1
ii  libkf6widgetsaddons6         6.11.0-1
ii  libmtp9t64                   1.1.22-1
ii  libopenexr-3-1-30            3.1.13-2
ii  libphonon4qt6-4t64           4:4.12.0-4
ii  libplasmaactivities6         6.3.2-1
ii  libplasmaactivitiesstats1    6.3.2-1
ii  libplist-2.0-4               2.6.0-2+b1
ii  libqt6core5compat6           6.8.2-3+b1
ii  libqt6core6t64               6.8.2+dfsg-5+b1
ii  libqt6dbus6                  6.8.2+dfsg-5+b1
ii  libqt6gui6                   6.8.2+dfsg-5+b1
ii  libqt6network6               6.8.2+dfsg-5+b1
ii  libqt6sql6                   6.8.2+dfsg-5+b1
ii  libqt6svg6                   6.8.2-3
ii  libqt6widgets6               6.8.2+dfsg-5+b1
ii  libsmbclient0                2:4.22.0+dfsg-1+b1
ii  libssh-4                     0.11.1-1
ii  libstdc++6                   14.2.0-19
ii  libtag2                      2.0.2-2
ii  libxcursor1                  1:1.2.3-1
ii  phonon4qt6                   4:4.12.0-4

Versions of packages kio-extras recommends:
ii  libkf6kcmutils-bin  6.11.0-1
ii  systemsettings      4:6.3.2-1

kio-extras suggests no packages.

-- no debconf information

Description: Backport upstream fixes for BUG 500173
 * Backport fixes for KDE bug Spurious windows while generating HTML preview in Wayland
 * closes: #(add debian bug here)
Author: Jonathan Rubenstein <jrubcop@gmail.com>
Bug-Debian: https://bugs.debian.org/(add debian bug here)

Origin: backport, https://invent.kde.org/network/kio-extras/-/merge_requests/412 & https://invent.kde.org/network/kio-extras/-/merge_requests/415
Bug: https://bugs.kde.org/show_bug.cgi?id=500173
Forwarded: not-needed
Applied-Upstream: master, https://invent.kde.org/network/kio-extras/-/commit/e11dfd86bd075afc7ff5c5eec70bc5d2377c4168
Reviewed-By: <name and email of someone who approved/reviewed the patch>
Last-Update: 2025-03-28

--- kio-extras-24.12.2.orig/thumbnail/CMakeLists.txt
+++ kio-extras-24.12.2/thumbnail/CMakeLists.txt
@@ -84,10 +84,13 @@ ecm_qt_declare_logging_category(kio_thum
 )
 
 target_link_libraries(kio_thumbnail
-    KF6::CoreAddons
-    KF6::KIOCore
-    KF6::KIOWidgets
-    KF6::I18n
+    PUBLIC
+        KF6::CoreAddons
+        KF6::KIOCore
+        KF6::KIOWidgets
+        KF6::I18n
+    PRIVATE
+        Qt6::GuiPrivate
 )
 
 install(TARGETS kio_thumbnail DESTINATION ${KDE_INSTALL_PLUGINDIR}/kf6/kio)
--- kio-extras-24.12.2.orig/thumbnail/thumbnail.cpp
+++ kio-extras-24.12.2/thumbnail/thumbnail.cpp
@@ -51,6 +51,9 @@
 
 #include "imagefilter.h"
 
+#include <private/qguiapplication_p.h> // QGuiApplicationPrivate::platformTheme()
+#include <qpa/qplatformtheme.h>
+
 // Recognized metadata entries:
 // mimeType     - the mime type of the file, used for the overlay icon if any
 // width        - maximum width for the thumbnail
@@ -101,6 +104,22 @@ extern "C" Q_DECL_EXPORT int kdemain(int
     // need QGuiApplication
     qunsetenv("SESSION_MANAGER");
 
+    // Some plugins may cause unwanted windows to appear
+    // (e.g. Webarchiver, see https://bugs.kde.org/show_bug.cgi?id=500173).
+    // This will not let any plugin to create auxilliary windows on the screen
+    // while generating thumbnails.
+    // Retrieve theme name from the default platform...
+    QString themeName;
+    {
+        QGuiApplication aux(argc, argv);
+        if (auto platformTheme = QGuiApplicationPrivate::platformTheme()) {
+            themeName = platformTheme->name();
+        }
+    }
+    // ...and force using offscreen platform with the default platform's theme
+    qputenv("QT_QPA_PLATFORM", "offscreen");
+    qputenv("QT_QPA_PLATFORMTHEME", themeName.toUtf8());
+
     // Some thumbnail plugins use QWidget classes for the rendering,
     // so use QApplication here, not just QGuiApplication
     QApplication app(argc, argv);

--- End Message ---
--- Begin Message --- 
Source: kio-extras
Source-Version: 4:25.03.90-1
Done: Aurélien COUDERC <coucouf@debian.org>

We believe that the bug you reported is fixed in the latest version of
kio-extras, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1101514@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aurélien COUDERC <coucouf@debian.org> (supplier of updated kio-extras package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 11 Apr 2025 23:18:44 +0200
Source: kio-extras
Architecture: source
Version: 4:25.03.90-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Aurélien COUDERC <coucouf@debian.org>
Closes: 1101514
Changes:
 kio-extras (4:25.03.90-1) unstable; urgency=medium
 .
   [ Aurélien COUDERC ]
   * New upstream release (25.03.90). (Closes: #1101514)
   * Update build-deps and deps with the info from cmake.
   * Bump Standards-Version to 4.7.2, no change required.
   * Refresh copyright information.
   * Add lintian overrides for source containing exe files, used as test
     data for the exe thumbnailer.
Checksums-Sha1:
 57cf37686e8740b2c9ef799864cfaeb99c41d92d 3527 kio-extras_25.03.90-1.dsc
 e0b4fb8521a5177fa56def153c924d67c2573596 3549236 kio-extras_25.03.90.orig.tar.xz
 2b3acdc439170ca6343c549ef424781094b23939 833 kio-extras_25.03.90.orig.tar.xz.asc
 b6672e3cfd7d13a4ba0ab5b48ec06fd60d80e255 18708 kio-extras_25.03.90-1.debian.tar.xz
 27f7638a99dfcf7e4409153a7b32d6932962d301 28902 kio-extras_25.03.90-1_amd64.buildinfo
Checksums-Sha256:
 c12c6110021c657fd1350b201b28f347bd1be679abad4e55aadedfc10c67dba9 3527 kio-extras_25.03.90-1.dsc
 c910074d61f92f09f36ae116516ed2066b2aa7feac6b1443467996835b941736 3549236 kio-extras_25.03.90.orig.tar.xz
 f9c61ce38dbd08f62456723e7a629f1b87797272c5dff60cc932849657343632 833 kio-extras_25.03.90.orig.tar.xz.asc
 f2f53a83abf20629c54329e5aea1c7436feb420dd7671389cbfd31ed192e7229 18708 kio-extras_25.03.90-1.debian.tar.xz
 7aac1bbccb3411cb3ede9c067df0c6597d0daad46058327ae326c3dc311b3cfa 28902 kio-extras_25.03.90-1_amd64.buildinfo
Files:
 0a0c3ff352d7b35881b4bbac6acc29e9 3527 kde optional kio-extras_25.03.90-1.dsc
 7d133d9650f7cd4bd8e518d70d4c9bdc 3549236 kde optional kio-extras_25.03.90.orig.tar.xz
 e47c74e643b1d71d026fcaac1b8385db 833 kde optional kio-extras_25.03.90.orig.tar.xz.asc
 835b95f63115e58287778278131948d7 18708 kde optional kio-extras_25.03.90-1.debian.tar.xz
 cc49461a506a81db94a3fe7cd2656c44 28902 kde optional kio-extras_25.03.90-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEEIW//QAAaDgcOKDsfcaflM/KRoyQFAmf5iwMTHGNvdWNvdWZA
ZGViaWFuLm9yZwAKCRBxp+Uz8pGjJLY6EACcnA17Dot9DieoBFCBt4FJmSG17zx+
G9VL8su7j2Mc8ifEu2vJ35Tsm4phHu+2o6TN9wh8DfHXc3yIzyN4d/mUoR2JSq64
GzsDWcvBEADRegORTcNxk7MiY6dz6CKaQuLiQ932U8Vbw5NMJQtxNydHP2Qj6376
7sNK+C7ZD98uvcu8k/17x9rVx3oe4qcKaSu+Gnj7D+tcioo9+fWN7HZXeAPNtqWv
mAwZ++ngs0wcif7K1Iys50LhXtQuU8jGtO73o7sU6Kinx6thglQfEuHdCS56+2pi
Y2bewFh2bF9I3ZCJWNlieNifm1yk7jdrAJwh9nLR0SGnJVHNeTibtktpdD7vOYxw
aJUItQ4TuI/evTM7FZtcet9L9boTiwSfB0K8Kk9ZiM92PFvXHtkP9s0y0htVypIA
0SvQyuTbKG4v8v2/dlwdrRIdQOsLAYf87VTPQBHuw7taNp2vO8z8Duj+98bZnOvK
aONa8BmxHCcXk/R1lfdPfDr2PT1kHfd38L8ZTyGUqp5Irw47FgVK9gcdtbsYD7C4
TytPkvTZINdYeYvmgkwBfefVzhUtTaYemyvm29+o7lrhJco+B0poMxmlnToJF1AA
jT5OtJltIM27p1TqDfA6FQQfTIUBhhj+aDsQzqrWYq+DtG4E2e1Yed8MkLs8gFTV
UOb5XfGeNejykA==
=K6RC
-----END PGP SIGNATURE-----

Attachment: pgp9wYIqprWYW.pgp
Description: PGP signature


--- End Message ---
Reply to: