Bug#1084874: extra-cmake-modules: skips part of the build when cross compiling

[Helmut Grohne <helmut@subdivi.de>]

Control: tags -1 + patch

On Thu, Oct 10, 2024 at 10:28:59AM +0200, Helmut Grohne wrote:
> The root cause of this failure resides in extra-cmake-modules, more
> precisely in kde_package_app_templates which does nothing when cross
> compiling. It otherwise works fine. It just refuses to do its thing. I
> argue that whether the function should skip itself or not is a decision
> of the caller, not the callee and thus propose to drop this
> functionality. Doing so makes kf6-kio cross buildable. I'm attaching a
> patch for your convenience.

Yes, I did mean to attach a patch.

Helmut

--- kf6-extra-cmake-modules-6.6.0.orig/kde-modules/KDEPackageAppTemplates.cmake
+++ kf6-extra-cmake-modules-6.6.0/kde-modules/KDEPackageAppTemplates.cmake
@@ -64,17 +64,11 @@ Deprecated:
 
 Multiple templates can be passed at once.
 
-This function does nothing when cross-compiling.
-
 
 Since 5.18
 #]=======================================================================]
 
 function(kde_package_app_templates)
-    if (CMAKE_CROSSCOMPILING)
-        return()
-    endif()
-
     set(_oneValueArgs INSTALL_DIR)
     set(_multiValueArgs TEMPLATES)
     cmake_parse_arguments(ARG "" "${_oneValueArgs}" "${_multiValueArgs}" ${ARGN} )