Bug#1072425: k3b: FTBFS with ffmpeg 7.0: k3bf fmpegwrapper.cpp:143:26: error: ‘AVCodecContext’ {aka ‘struct AVCodecContext’} has no member named ‘channels’ xt’ {aka ‘struct AVCodecContext’} has n o member named ‘channels’

[Aurélien COUDERC <libre@coucouf.fr>]

Le 1 août 2024 00:39:05 GMT+02:00, Diederik de Haas <sourcehut@cknow.org> a écrit :
>On dinsdag 23 juli 2024 17:56:34 CEST you wrote:
>> > during a rebuild of the reverse dependencies for the transition to
>> > ffmpeg 7.0, your package failed to build
>> 
>> In the upstream git repo there are 2 commits on 2024-04-13 which probably do
>> fix the FTBFS issue, but don't make it compatible with ffmpeg 7.0. F.e. it
>> now just returns '0' for the number of channels with ffmpeg 7.0, while it
>> does return the actual value when < 7.0 ...
>> 
>> So, linking to those commits seems pointless.
>
>No offense, but I don't consider the following a solution:
>```
>int K3bFFMpegFile::channels() const
>{
>#if LIBAVCODEC_VERSION_MAJOR < 61
>    return d->codecContext->channels;
>#else
>#pragma Unimplemented
>    return 0;
>#endif
>}
>```
>(Upstream commits 712ef4adc992 + 071535a79c3d)
>
>I'm sure it does fix the FTBFS problem, so this is just to inform users
>if they care about it.

Ack and agreed.

I'll try working on a better patch. It seems doable after a quick look at the ffmpeg documentation.


Thanks for the feedback.


--
Aurélien