[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1059631: marked as done (qhelpgenerator-qt5: nearly-reproducible LastRegisterTime value in .qch files is not timezone-normalized)

Your message dated Sun, 18 Feb 2024 00:38:28 +0000
with message-id <E1rbVCO-004jN3-3a@fasolo.debian.org>
and subject line Bug#1059631: fixed in qttools-opensource-src 5.15.10-6
has caused the Debian Bug report #1059631,
regarding qhelpgenerator-qt5: nearly-reproducible LastRegisterTime value in .qch files is not timezone-normalized
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1059631: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1059631
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: qhelpgenerator-qt5
Version: 5.15.2-3
Severity: wishlist
User: reproducible-builds@lists.alioth.debian.org
Usertags: timezone
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Dear Maintainer,

Looking at some recent Reproducible Build[1] test results[2] for the Debian
openorienteering-mapper package, the LastRegisterTime value placed into the
SettingsTable table in the .qch (sqlite3 db) file format can vary based on
the build host's configuration.

Inspecting the patch from #875847 and the values that appear in the diffoscope
output from the build logs: the SOURCE_DATE_EPOCH value of the build is used,
as expected, to improve the reproducibility of the build.  It takes the value
of the most recent Debian changelog entry.

However: the patch mutates an existing QT QDateTime instance (last_modified) to
store the seconds-since-epoch value -- without specifying a timezone for the
value.

I'm not 100% certain, but I think it's likely (given that the duration
between the two timestamps that appear in the diffoscope output is 26 hours,
equal to the local-time-difference between GMT-14 and GMT+12, the two build
timezones) that the last_modified object remains timezone-relative in each
build, and therefore emits differing LastRegisterTime values in ISO format.

  -INSERT INTO SettingsTable VALUES('LastRegisterTime','2021-12-27T21:45:41.000');
  +INSERT INTO SettingsTable VALUES('LastRegisterTime','2021-12-28T23:45:41.000');

My sense is that the LastRegisterTime column value is probably intended to be
stored in UTC; it may be sufficient to set the timezone of the last_modified
instance to UTC -- making careful to ensure that it is indeed a _set_ timezone
operation and not a _translate_ timezone operation.

Regards,
James

[1] - https://reproducible-builds.org/

[2] - https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/arm64/diffoscope-results/openorienteering-mapper.html

[3] - https://doc.qt.io/qt-5/qdatetime.html

--- End Message ---
--- Begin Message --- 
Source: qttools-opensource-src
Source-Version: 5.15.10-6
Done: Dmitry Shachnev <mitya57@debian.org>

We believe that the bug you reported is fixed in the latest version of
qttools-opensource-src, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1059631@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dmitry Shachnev <mitya57@debian.org> (supplier of updated qttools-opensource-src package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 17 Feb 2024 15:27:24 +0300
Source: qttools-opensource-src
Architecture: source
Version: 5.15.10-6
Distribution: unstable
Urgency: medium
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Dmitry Shachnev <mitya57@debian.org>
Closes: 1059592 1059631
Changes:
 qttools-opensource-src (5.15.10-6) unstable; urgency=medium
 .
   * Backport upstream patch to ensure FileAttributeSetTable is filled
     ordered (closes: #1059592).
   * Backport upstream patch to localize SOURCE_DATE_EPOCH to UTC in
     qhelpgenerator (closes: #1059631).
Checksums-Sha1:
 dee81e367f266c61162f183800de2cf7e3ee195c 4065 qttools-opensource-src_5.15.10-6.dsc
 9cca5ac3d583b29385d8fb24af274c96dd11fbd8 49612 qttools-opensource-src_5.15.10-6.debian.tar.xz
 602a3ec07a70361c09b1d956da8f5a27cbe53f2f 14004 qttools-opensource-src_5.15.10-6_source.buildinfo
Checksums-Sha256:
 af64a4dcf71c22d9221edb3004071aa8dc3f708a5228016ca4347bc40a1e7402 4065 qttools-opensource-src_5.15.10-6.dsc
 c6d3e10c9099ef6aa080a0a81566ed99b9db9ebcf8065ed41a920ecf60f1b79f 49612 qttools-opensource-src_5.15.10-6.debian.tar.xz
 3fdf3af43a8cde1fa36d9be110c6e952e6e91f72473947c6b907751aa4a12d36 14004 qttools-opensource-src_5.15.10-6_source.buildinfo
Files:
 1cb93e97e56c579895fe20d63aa2ea65 4065 libs optional qttools-opensource-src_5.15.10-6.dsc
 6587283bb9f81f01d3945d0c700a4b29 49612 libs optional qttools-opensource-src_5.15.10-6.debian.tar.xz
 379a11d9ce074336a47e2ac35c2010ad 14004 libs optional qttools-opensource-src_5.15.10-6_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEEq2sdvrA0LydXHe1qsmYUtFL0RrYFAmXQpnYTHG1pdHlhNTdA
ZGViaWFuLm9yZwAKCRCyZhS0UvRGtmQAD/9NE1wIoL4YASkq5hTaAQIKErsusSGu
e4ls5sswm49E0fdwCQgw/xToCpkhfa0zi+Vb4RqGOJWAlETLXZMkqO/RbXaXbaGY
RS5QYpcC7JP0axglD0zDISLcbfihdGey1o+kkcAt2UHuJFPEXgckRrb9WfrsqvU8
kHcTy228b7J8jEDYCI6WFmjg0UNE813Gb4Gv4N/G/ITu9HyPnc6ErT55Bpbx1xQE
ZozEigDWRbAXwE1Fq/huWtP7x/OlnvYnVN7kLLHZFqfiO/SPfvnOEb+mh9SrBAFQ
qNDWoSQ4TDPwwtCIwJw/nCl/y3+NBPf3kQ/z2NyIs4ObUUntaIhJCXA5bXr6Dzlw
2anhXrmzW0zAR2cUNpre6gvp12/vy/vCSbmfcuALUBCcWguYgZdYp4qRVYJnbqbU
g7UaKnM6ybvIKbzpcz9qiHpb5xALsQVLrjTLs7j/AIVzc0uZLNGbD7n1avckACmI
jIIOfJOWSoreZ8eeGj/Y8/3c9aRNXvCoqNJ0PLRnKCln4waqFq95B08mEHWe8xB2
oWP/aZADa3E1iuSAzPeFwxuE5alajcgtLQmAsPWxqeL5FAPfSJJKQRKzW+4SDII1
YLkoimfmL81NZAulH1vwPaP0QvayNGBbxVZxOQKFrf3ZCg6fQ4gaXJCTAy8kuPU1
GpCa91ZWDRqSyA==
=hBlK
-----END PGP SIGNATURE-----

Attachment: pgp9TggH2b2Ew.pgp
Description: PGP signature


--- End Message ---
Reply to: