tags 1023334 - moreinfo -- On Monday, July 3, 2023 11:14:31 PM MST Yadd wrote: > On 7/4/23 07:53, Soren Stoutner wrote: > > I am generally unfamiliar with some of these JavaScript packages, > > although my intention is to replace any system copies that exist. I see > > that you have filed a similar bug with qt6-webengine, although Patrick > > considers it to be a false positive. > > > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023333 > > <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023333> > > Hi, > > when I rebuilt all reverse dependencies of rollup, I filed a bug against > all packages where build failed at rollup step. If this is fixed now, > you can close this bug. This package currently builds fine, however, I would like to investigate removing the bundled copy of rollup first to make sure it isn’t being used in any way. > > My guess is that whatever rollup code exists in Qt WebEngine is > > inherited from Chromium, but I don’t see a bug report there. > > In JS world, you can fix a dependency version. Then it's normal to not > have any bug if the version 2 of rollup is required. > > > Can you please explain the procedure you used to try to build > > qtwebengine-opensource-src (qt5-webengine) with the system rollover and > > how it failed? > > simply sbuild Given that you previously produced an error building the package with sbuild and the system version 3 of rollup, that would indicate to me that the build process is preferring the system version to whatever is bundled with the source. However, I am going to try a build with the bundled version removed first to make sure before closing the bug. > > I see that the current package (5.15.13+dfsg-4) build depends on the > > current versions of rollup and node-rollup-plugin-terser, but that > > doesn’t necessarily mean that they are being used instead of an embedded > > copy. It appears that we might be currently, unintentionally shipping > > an embedded copy in: > > > > ./src/3rdparty/chromium/third_party/devtools-frontend/src/node_modules/rol > > lup > > > > Any help you can provide to point us in the right direction would be > > appreciated. > > If you have a bug at rollup step, simply send me your log and I'll > provide the patch I appreciate the assistance. You have provided me enough information to start working on this. If I get stuck I will be happy to reach out to you with a build log. I am fairly new to the Qt WebEngine and Chromium world and wasn’t involved with the Debian packages when this bug was first filed. There probably hasn’t been anyone focused on Qt WebEngine in Debian as much as I intend to focus on it going forward. But it is a large and complicated code base. There probably isn’t any single person in the world who understands in detail all of what it is doing, so it is valuable to have resources. -- Soren Stoutner soren@stoutner.com
Attachment:
signature.asc
Description: This is a digitally signed message part.