[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#906966: marked as done (kdesignerplugin FTCBFS: KF5::kgendesignerplugin: not found)

Your message dated Fri, 23 Dec 2022 21:15:09 +0100
with message-id <[🔎] 1771466.TLkxdtWsSY@grummly>
and subject line Re: Bug#906966: fixing again in kdesignerplugin 5.101.0-2
has caused the Debian Bug report #906966,
regarding kdesignerplugin FTCBFS: KF5::kgendesignerplugin: not found
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
906966: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=906966
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: kdesignerplugin
Version: 5.49.0-1
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

kdesignerplugin fails to cross build from source, because it cannot find
KF5::kgendesignerplugin. During native builds it refers to an executable
that is both used during build and installed to the package. So rather
than using the built one, we need to use the system copy. The attached
patch implements that and makes kdesignerplugin cross build
successfully. Please consider applying it.

Helmut

diff --minimal -Nru kdesignerplugin-5.49.0/debian/changelog kdesignerplugin-5.49.0/debian/changelog
--- kdesignerplugin-5.49.0/debian/changelog	2018-08-17 16:18:21.000000000 +0200
+++ kdesignerplugin-5.49.0/debian/changelog	2018-08-22 20:35:08.000000000 +0200
@@ -1,3 +1,11 @@
+kdesignerplugin (5.49.0-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Use the system kgendesignerplugin for cross building.
+    (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Wed, 22 Aug 2018 20:35:08 +0200
+
 kdesignerplugin (5.49.0-1) unstable; urgency=medium
 
   * New upstream release (5.48.0).
diff --minimal -Nru kdesignerplugin-5.49.0/debian/control kdesignerplugin-5.49.0/debian/control
--- kdesignerplugin-5.49.0/debian/control	2018-08-17 16:18:21.000000000 +0200
+++ kdesignerplugin-5.49.0/debian/control	2018-08-22 20:35:07.000000000 +0200
@@ -6,6 +6,7 @@
 Build-Depends: cmake (>= 3.0~),
                debhelper (>= 11~),
                extra-cmake-modules (>= 5.49.0~),
+               kgendesignerplugin-bin <cross>,
                libkf5completion-dev (>= 5.49.0~),
                libkf5config-dev (>= 5.49.0~),
                libkf5configwidgets-dev (>= 5.49.0~),
diff --minimal -Nru kdesignerplugin-5.49.0/debian/patches/cross.patch kdesignerplugin-5.49.0/debian/patches/cross.patch
--- kdesignerplugin-5.49.0/debian/patches/cross.patch	1970-01-01 01:00:00.000000000 +0100
+++ kdesignerplugin-5.49.0/debian/patches/cross.patch	2018-08-22 20:35:08.000000000 +0200
@@ -0,0 +1,17 @@
+--- kdesignerplugin-5.49.0.orig/src/CMakeLists.txt
++++ kdesignerplugin-5.49.0/src/CMakeLists.txt
+@@ -11,7 +11,13 @@
+   ${kdesignerplugin_QM_LOADER}
+ )
+ add_executable(kgendesignerplugin ${kgendesignerplugin_SRCS})
+-add_executable(KF5::kgendesignerplugin ALIAS kgendesignerplugin)
++if(CMAKE_CROSSCOMPILING)
++    find_program(KGENDESIGNERPLUGIN_EXECUTABLE kgendesignerplugin)
++    add_executable(KF5::kgendesignerplugin IMPORTED GLOBAL)
++    set_target_properties(KF5::kgendesignerplugin PROPERTIES IMPORTED_LOCATION ${KGENDESIGNERPLUGIN_EXECUTABLE})
++else()
++    add_executable(KF5::kgendesignerplugin ALIAS kgendesignerplugin)
++endif()
+ ecm_mark_nongui_executable(kgendesignerplugin)
+ 
+ target_link_libraries(kgendesignerplugin KF5::ConfigCore # KConfig + KConfigGroup
diff --minimal -Nru kdesignerplugin-5.49.0/debian/patches/series kdesignerplugin-5.49.0/debian/patches/series
--- kdesignerplugin-5.49.0/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ kdesignerplugin-5.49.0/debian/patches/series	2018-08-22 20:35:08.000000000 +0200
@@ -0,0 +1 @@
+cross.patch

--- End Message ---
--- Begin Message --- 
control: fixed -1 5.101.0-2

Dear Helmut,

Le jeudi 15 décembre 2022, 10:01:57 CET Helmut Grohne a écrit :
> Control: reopen -1
> Control: found -1 5.83.0-1
> 
> On Wed, Nov 07, 2018 at 05:27:04PM +0000, Debian Bug Tracking System wrote:
> > #906966: kdesignerplugin FTCBFS: KF5::kgendesignerplugin: not found
> > 
> > It has been closed by Maximiliano Curia <maxy@debian.org>.
> 
> The fix has been reverted in 5.83.0-1. Would someone know why?

I’ve adapted and reinstated the patch and uploaded it in 5.101.0-2.


Happy hacking,
--
Aurélien

--- End Message ---
Reply to: