Hi Dennis!
On Sat, Oct 15, 2022 at 01:51:16PM +0200, Dennis Filder wrote:
> Control: tag -1 + patch
>
> The attached patch fixed the crashes of Linphone for me.
Thank you for the patch. I let the upstream maintainers know about it
in https://bugreports.qt.io/browse/QTBUG-84858#comment-684786.
However, if you can make an account on Qt Gerrit [1][2] and submit your
patch there, it would speed up the review process.
I think there are some style issues with your patch: instead of using a
name starting with underscore and __attribute__((visibility("hidden"))),
it would be better to add a new method to QQuickItemPrivate class.
In that method, "this" instance would become what was "d", and if you use
Q_Q(QQuickItemPrivate), "q" object would become what was "this".
Our general policy is to get patches merged (or at least approved)
upstream, before including them into Debian.
[1]: https://codereview.qt-project.org/
[2]: https://wiki.qt.io/Setting_up_Gerrit
--
Dmitry Shachnev
Attachment:
signature.asc
Description: PGP signature