[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#966036: kajongg: Uses old name of sip module



Hi Dmitry,

apparently I missed this sip-related bug.

In data mercoledì 22 luglio 2020 13:31:19 CET, Dmitry Shachnev ha scritto:
> Source: kajongg
> Version: 4:19.12.3-1
> Usertags: sip5
> 
> Dear Maintainer,
> 
> You are receiving this bug because your package seems to be using PyQt5
> and has Python files with "import sip" lines.
> 
> With the latest version of PyQt5 in experimental, the private sip module
> used by PyQt5 is called "PyQt5.sip", not just "sip". I am going to upload
> this version to unstable around end of August.
> 
> You may need to update your imports to do something like this:
> 
> try:
>     from PyQt5 import sip
> except ModuleNotFoundError:
>     import sip
> 
> Alternatively, you may import sip after importing PyQt5. So the following
> will work too:
> 
> from PyQt5 import QtCore
> import sip
> 
> Please see the following link for details:
> 
> https://www.riverbankcomputing.com/static/Docs/PyQt5/incompatibilities.html#importing-the-sip-module
> 
> If you use sip for reasons unrelated to PyQt5, you may leave the old import
> as is, but please bear in mind that sip4 is deprecated.
> 
> Also, calls like "sip.setapi('QDate', 2)" are not needed at all with PyQt5.
> They were needed only with PyQt4 and Python 2. It is safe to delete them.
> 
> For the actual documentation of sip module, see the following link:
> 
> https://www.riverbankcomputing.com/static/Docs/PyQt5/api/sip/sip-module.html

It seems the sip-related bits are still the same. It looks to me that
sip is used for the following this:
1) sip.unwrapinstance()
2) sip.SIP_VERSION_STR (printed in the about dialog)
3) sip.cast()

I do not know whether it is possible to "do stuff" without using them;
would it be possible for you (not a priority though) to send patches
upstream in case?
https://invent.kde.org/games/kajongg
It definitely should be easier than with krita... ;-)

Thanks,
-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: