[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#762450: marked as done (kmahjongg: invocation of qrand() without first invoking qsrand())

Your message dated Sun, 02 Aug 2020 08:45:25 +0000
with message-id <E1k29cT-0004bh-Ch@fasolo.debian.org>
and subject line Bug#762450: fixed in kmahjongg 4:20.04.3-1
has caused the Debian Bug report #762450,
regarding kmahjongg: invocation of qrand() without first invoking qsrand()
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
762450: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762450
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: kmahjongg
Version: 4:4.14.0-1
Severity: normal
Tags: upstream

Dear Maintainer,

kmahjongg provides a configuration option which claims to make it select
random board layouts when starting a new game.

This option selects a board layout using the following statement:

    return tilesAvailable.at(qrand() % tilesAvailable.size());

However, at no point does kmahjongg call the qsrand() function, which is
required in order to *initialize* the pseudorandom number generator invoked
via qrand().

The visible symptom of this bug is that when launching the game with the
"random boards" configuration option enabled, the board selected is *almost
always* the same.

(The arrangement of the individual tiles *within* the layout is correctly
randomized, since that task is done using an object of class KRandomSequence,
whose constructor forces it to be correctly initialized.)

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.14-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages kmahjongg depends on:
ii  kde-runtime              4:4.13.1-1
ii  kdegames-mahjongg-data   4:4.13.1-1
ii  libc6                    2.19-11
ii  libkdecore5              4:4.14.0-1
ii  libkdegames6abi1         4:4.13.1-1
ii  libkdegamesprivate1abi1  4:4.13.1-1
ii  libkdeui5                4:4.14.0-1
ii  libkio5                  4:4.14.0-1
ii  libkmahjongglib4         4:4.13.1-1
ii  libqtcore4               4:4.8.6+git64-g5dc8b2b+dfsg-2
ii  libqtgui4                4:4.8.6+git64-g5dc8b2b+dfsg-2
ii  libstdc++6               4.9.1-14

Versions of packages kmahjongg recommends:
ii  khelpcenter4  4:4.13.1-1

kmahjongg suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: kmahjongg
Source-Version: 4:20.04.3-1
Done: Pino Toscano <pino@debian.org>

We believe that the bug you reported is fixed in the latest version of
kmahjongg, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 762450@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Pino Toscano <pino@debian.org> (supplier of updated kmahjongg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 02 Aug 2020 09:53:24 +0200
Source: kmahjongg
Architecture: source
Version: 4:20.04.3-1
Distribution: unstable
Urgency: medium
Maintainer: Debian/Kubuntu Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Pino Toscano <pino@debian.org>
Closes: 762450
Changes:
 kmahjongg (4:20.04.3-1) unstable; urgency=medium
 .
   * Team upload.
   * New upstream release:
     - switches from qrand() to QRandomGenerator (Closes: #762450)
   * Update watch file to the new release-service location.
   * Drop the Debian man page, as it is outdated, and it offers no useful
     information.
   * Update the build dependencies according to the upstream build system:
     - bump cmake to 3.5
     - bump Qt packages to 5.9.0
     - bump KF packages to 5.46.0
     - explicitly add gettext
   * Switch from dhmk to the dh sequencer:
     - invoke the dh sequencer using the kf5 addon
     - call the right debhelper command instead of $(overridden_command)
     - manually force the generation of the substvars for the kde-l10n breaks
   * Bump the debhelper compatibility to 12:
     - switch the debhelper build dependency to debhelper-compat 12
     - remove debian/compat
   * Add Rules-Requires-Root: no.
   * Bump Standards-Version to 4.5.0, no changes required.
   * Switch cmake parameter BIN_INSTALL_DIR to KDE_INSTALL_BINDIR, as the former
     is deprecated.
   * Add the configuration for the CI on salsa.
Checksums-Sha1:
 6c1bc9fbc0e1c48b79150fd370d49395e8a8b6ca 2895 kmahjongg_20.04.3-1.dsc
 90e69875ea1c4f47983f099b84b3058085659f70 3428000 kmahjongg_20.04.3.orig.tar.xz
 8209ff821b7ac7a2968f3bb82a7b3f7935a749bd 488 kmahjongg_20.04.3.orig.tar.xz.asc
 5faf538c8074281fe3ef9f5a8cc8ae8b8398acea 10916 kmahjongg_20.04.3-1.debian.tar.xz
 b81d5c46a0354075ea51a886a33dc0782b4a1e21 20527 kmahjongg_20.04.3-1_source.buildinfo
Checksums-Sha256:
 1ac766d467bdcc4c2cbb84defe126579dca621f51764cde47d99c75c5e9b99ee 2895 kmahjongg_20.04.3-1.dsc
 1f4fce58163323c23aa37f849e556ee4ed7fe33fb36e21754116e1d0e2c33673 3428000 kmahjongg_20.04.3.orig.tar.xz
 7a1048d78cf900952ed2dbb06fbef0ebaf1ba1bc678064c7046584d4ce738197 488 kmahjongg_20.04.3.orig.tar.xz.asc
 30e4b434a5edbcc3f5a401993d4722ced6aa2674eb75b8b2095b373ad1393c55 10916 kmahjongg_20.04.3-1.debian.tar.xz
 7eb47cc67fa760abb5d1342a7641223ebf74607de98f99f2c080860c50d77855 20527 kmahjongg_20.04.3-1_source.buildinfo
Files:
 0e28aa7534f368674471d1823b02e330 2895 games optional kmahjongg_20.04.3-1.dsc
 15950c41ffb30668bc451242da466536 3428000 games optional kmahjongg_20.04.3.orig.tar.xz
 86fa41083b00b3cdf0381853b62398a3 488 games optional kmahjongg_20.04.3.orig.tar.xz.asc
 90b4cd77d8b479ee1897304aaacfdbe4 10916 games optional kmahjongg_20.04.3-1.debian.tar.xz
 2c5a55b8261da0554ca6d2ffdf0aa607 20527 games optional kmahjongg_20.04.3-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEXyqfuC+mweEHcAcHLRkciEOxP00FAl8mcRkACgkQLRkciEOx
P03YFA//XdvsmR4fBHvoKDVENUvH4kmql2eAUcGGLZVfOIR7mGd5fCQMSKOPXQFL
26DhaGeC/yWa1bJw2c+bePsZLMf5FNW95FxyAYy4aBL5BIYohUhDX2YWKe0yO3Kk
uABfdPWSvxMtTeYwduPYOeiqnuxSPB5xomobMBj31ppr02hZnWZSQHTY78zdnGg4
kLmDlDSVjoU1cKBR5kY6kmpjqLKyGLmm5ASKaw61ocrdkxaALBVqvUh0uSjku4yz
TCaSoRi3OzoEiaxIlQVSl9QH5U1/oIrbY+2wI3dcOCr48/zguXCUEQGfNhGFw1dE
rB0HM5UAsZTkOCDwx0MI6pBnCiI7UVTLRJABtV72SbVPioFpMUPEfVxpGjbIm3sl
2J6/jnklHUrD/htsQOzVrX/YO7kdWMKmva6MvO30Vs4Wvi6TXzJUXJHZ/mj6nbFK
8vUqghftvU3U2YCIFM0pRlpeqA+95n8ZsHNzCWSKVSDBoZ+PDwLDTTKvJ/YaFBZS
Bg1gRErg/M73+fES6/pgw8SuNEzuIvCpo+T8N1zsevIwDxUP5TURFt7IAYX5OKmR
z5agreqYYuSzAzfnJGEEgqx5EboyIwiqTs+/Cov/k2XHjFy8fFr4JT+NJu5Cvmhg
R3fnEKcu8BNABuRsJG+WSHOwoYnU8iXAGSe7Vcg9VQ1O4bKQo4A=
=tk+W
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: