Bug#964690: signon-plugin-oauth2: FTBFS: oauth1plugin.cpp:147:51: error: ‘void QUrl::addQueryItem(const QString&, const QString&)’ is deprecated [-Werror=deprecated-declarations]
Source: signon-plugin-oauth2
Version: 0.22-1
Severity: serious
Justification: FTBFS on amd64
Tags: bullseye sid ftbfs
Usertags: ftbfs-20200709 ftbfs-bullseye
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
Relevant part (hopefully):
> g++ -c -pipe -fno-exceptions -fno-rtti -Werror -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>/src=. -fstack-protector-strong -Wformat -Werror=format-security -O2 -Wall -Wextra -D_REENTRANT -fPIC -DSIGNON_TRACE -DQT_CORE_LIB -DQT_NO_DEBUG -DQT_PLUGIN -DQT_XMLPATTERNS_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -isystem /usr/include/signon-qt5 -isystem /usr/include/signon-qt5/SignOn -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/signon-plugins -isystem /usr/include/signon-plugins/SignOn -isystem /usr/include/x86_64-linux-gnu/qt5/QtXmlPatterns -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -I. -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -o oauth1plugin.o oauth1plugin.cpp
> oauth1plugin.cpp: In member function ‘void OAuth2PluginNS::OAuth1Plugin::sendOAuth1AuthRequest()’:
> oauth1plugin.cpp:147:51: error: ‘void QUrl::addQueryItem(const QString&, const QString&)’ is deprecated [-Werror=deprecated-declarations]
> 147 | url.addQueryItem(OAUTH_TOKEN, d->m_oauth1Token);
> | ^
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qurl.h:419,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborvalue.h:51,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborarray.h:43,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/QtCore:38,
> from oauth1plugin.h:27,
> from oauth1plugin.cpp:26:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qurlquery.h:124:13: note: declared here
> 124 | inline void QUrl::addQueryItem(const QString &key, const QString &value)
> | ^~~~
> oauth1plugin.cpp:150:60: error: ‘void QUrl::addQueryItem(const QString&, const QString&)’ is deprecated [-Werror=deprecated-declarations]
> 150 | url.addQueryItem(SCREEN_NAME, d->m_oauth1ScreenName);
> | ^
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qurl.h:419,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborvalue.h:51,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborarray.h:43,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/QtCore:38,
> from oauth1plugin.h:27,
> from oauth1plugin.cpp:26:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qurlquery.h:124:13: note: declared here
> 124 | inline void QUrl::addQueryItem(const QString &key, const QString &value)
> | ^~~~
> oauth1plugin.cpp:151:60: error: ‘void QUrl::addQueryItem(const QString&, const QString&)’ is deprecated [-Werror=deprecated-declarations]
> 151 | url.addQueryItem(FORCE_LOGIN, d->m_oauth1ScreenName);
> | ^
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qurl.h:419,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborvalue.h:51,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborarray.h:43,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/QtCore:38,
> from oauth1plugin.h:27,
> from oauth1plugin.cpp:26:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qurlquery.h:124:13: note: declared here
> 124 | inline void QUrl::addQueryItem(const QString &key, const QString &value)
> | ^~~~
> oauth1plugin.cpp: In member function ‘QByteArray OAuth2PluginNS::OAuth1Plugin::constructSignatureBaseString(const QString&, const OAuth2PluginNS::OAuth1PluginData&, const QString&, const QString&)’:
> oauth1plugin.cpp:361:69: error: ‘QList<QPair<QString, QString> > QUrl::queryItems() const’ is deprecated [-Werror=deprecated-declarations]
> 361 | QList<QPair<QString, QString> > queryItems = fullUrl.queryItems();
> | ^
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qurl.h:419,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborvalue.h:51,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborarray.h:43,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/QtCore:38,
> from oauth1plugin.h:27,
> from oauth1plugin.cpp:26:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qurlquery.h:126:40: note: declared here
> 126 | inline QList<QPair<QString, QString> > QUrl::queryItems() const
> | ^~~~
> oauth1plugin.cpp: In member function ‘virtual void OAuth2PluginNS::OAuth1Plugin::userActionFinished(const SignOn::UiSessionData&)’:
> oauth1plugin.cpp:506:36: error: ‘bool QUrl::hasQueryItem(const QString&) const’ is deprecated [-Werror=deprecated-declarations]
> 506 | if (url.hasQueryItem(AUTH_ERROR)) {
> | ^
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qurl.h:419,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborvalue.h:51,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborarray.h:43,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/QtCore:38,
> from oauth1plugin.h:27,
> from oauth1plugin.cpp:26:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qurlquery.h:128:13: note: declared here
> 128 | inline bool QUrl::hasQueryItem(const QString &key) const
> | ^~~~
> oauth1plugin.cpp:508:77: error: ‘QString QUrl::queryItemValue(const QString&) const’ is deprecated [-Werror=deprecated-declarations]
> 508 | emit error(Error(Error::NotAuthorized, url.queryItemValue(AUTH_ERROR)));
> | ^
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qurl.h:419,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborvalue.h:51,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborarray.h:43,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/QtCore:38,
> from oauth1plugin.h:27,
> from oauth1plugin.cpp:26:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qurlquery.h:130:16: note: declared here
> 130 | inline QString QUrl::queryItemValue(const QString &key) const
> | ^~~~
> oauth1plugin.cpp:512:40: error: ‘bool QUrl::hasQueryItem(const QString&) const’ is deprecated [-Werror=deprecated-declarations]
> 512 | if (url.hasQueryItem(OAUTH_VERIFIER)) {
> | ^
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qurl.h:419,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborvalue.h:51,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborarray.h:43,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/QtCore:38,
> from oauth1plugin.h:27,
> from oauth1plugin.cpp:26:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qurlquery.h:128:13: note: declared here
> 128 | inline bool QUrl::hasQueryItem(const QString &key) const
> | ^~~~
> oauth1plugin.cpp:513:69: error: ‘QString QUrl::queryItemValue(const QString&) const’ is deprecated [-Werror=deprecated-declarations]
> 513 | d->m_oauth1TokenVerifier = url.queryItemValue(OAUTH_VERIFIER);
> | ^
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qurl.h:419,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborvalue.h:51,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborarray.h:43,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/QtCore:38,
> from oauth1plugin.h:27,
> from oauth1plugin.cpp:26:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qurlquery.h:130:16: note: declared here
> 130 | inline QString QUrl::queryItemValue(const QString &key) const
> | ^~~~
> oauth1plugin.cpp:518:44: error: ‘bool QUrl::hasQueryItem(const QString&) const’ is deprecated [-Werror=deprecated-declarations]
> 518 | else if (url.hasQueryItem(OAUTH_PROBLEM)) {
> | ^
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qurl.h:419,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborvalue.h:51,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborarray.h:43,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/QtCore:38,
> from oauth1plugin.h:27,
> from oauth1plugin.cpp:26:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qurlquery.h:128:13: note: declared here
> 128 | inline bool QUrl::hasQueryItem(const QString &key) const
> | ^~~~
> oauth1plugin.cpp:519:66: error: ‘QString QUrl::queryItemValue(const QString&) const’ is deprecated [-Werror=deprecated-declarations]
> 519 | handleOAuth1ProblemError(url.queryItemValue(OAUTH_PROBLEM));
> | ^
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qurl.h:419,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborvalue.h:51,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/qcborarray.h:43,
> from /usr/include/x86_64-linux-gnu/qt5/QtCore/QtCore:38,
> from oauth1plugin.h:27,
> from oauth1plugin.cpp:26:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qurlquery.h:130:16: note: declared here
> 130 | inline QString QUrl::queryItemValue(const QString &key) const
> | ^~~~
> cc1plus: all warnings being treated as errors
> make[2]: *** [Makefile:441: oauth1plugin.o] Error 1
The full build log is available from:
http://qa-logs.debian.net/2020/07/09/signon-plugin-oauth2_0.22-1_unstable.log
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.
Reply to: