[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#879014: gpgme1.0: FTBFS on some arches: Qt needs a compile with -fPIC (PIE is not enough), hardening downgrades to PIE



Hi Daniel!

On Wed, Jul 01, 2020 at 05:20:40PM -0400, Daniel Kahn Gillmor wrote:
> gniibe also identified a problem in how Qt reports compilation warnings
> related to the PIE/PIC mismatch.  I've tried to address that in the
> following patch to qtbase-opensource-src:
>
> From 107f387ea625a67ef03b916ef965761f36de2bf4 Mon Sep 17 00:00:00 2001
> From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
> Date: Wed, 1 Jul 2020 17:15:12 -0400
> Subject: [PATCH] Clarify warning message about PIC/PIE
>
> As noted in discussion at https://dev.gnupg.org/T4982#135524, the
> warning message produced when there is a mismatch between
> position-independence of the Qt library and other compilations, the
> warning produced by Qt is confusing.
>
> This is an attempt to express a warning that is more closely aligned
> with the actual test used.

Thanks for the patch! I have forwarded it upstream, with minor commit
message corrections:

https://codereview.qt-project.org/c/qt/qtbase/+/307046

--
Dmitry Shachnev

Attachment: signature.asc
Description: PGP signature


Reply to: