[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#887638: marked as done (kactivitymanagerd FTCBFS: broken C++11 feature checks using try_run)

Your message dated Sat, 26 Dec 2020 18:12:32 +0100
with message-id <3914642.GUh0CODmnK@thyrus>
and subject line Re: Bug#887638: kactivitymanagerd FTCBFS: broken C++11 feature checks using try_run
has caused the Debian Bug report #887638,
regarding kactivitymanagerd FTCBFS: broken C++11 feature checks using try_run
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
887638: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=887638
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: kactivitymanagerd
Version: 5.10.5-2
Tags: patch upstream
User: helmutg@debian.org
Usertags: rebootstrap

kactivitymanagerd fails to cross build from source, because it checks
for standard C++11 features (such as auto) with try_run. The build
doesn't depend on these check results in any way and the upstream source
pretty much assumes working auto. Thus these checks do not add any
value. After removing them, kactivitymanagerd cross builds successfully.
Please consider applying the attached patch.

Helmut

Index: kactivitymanagerd-5.10.5/src/CMakeLists.txt
===================================================================
--- kactivitymanagerd-5.10.5.orig/src/CMakeLists.txt
+++ kactivitymanagerd-5.10.5/src/CMakeLists.txt
@@ -21,16 +21,6 @@
    add_definitions (-fexceptions)
 endif ()
 
-# Testing for C++0x/C++11 features
-include (CheckCxxFeatures)
-cxx_check_feature ("c++11" "auto"               "N2546" HAVE_CXX11_AUTO               "${ADDITIONAL_DEFINITIONS}")
-cxx_check_feature ("c++11" "nullptr"            "N2431" HAVE_CXX11_NULLPTR            "${ADDITIONAL_DEFINITIONS}")
-cxx_check_feature ("c++11" "lambda"             "N2927" HAVE_CXX11_LAMBDA             "${ADDITIONAL_DEFINITIONS}")
-cxx_check_feature ("c++11" "override"           "N3206" HAVE_CXX11_OVERRIDE           "${ADDITIONAL_DEFINITIONS}")
-cxx_check_feature ("c++11" "unique_ptr"         "none"  HAVE_CXX11_UNIQUE_PTR         "${ADDITIONAL_DEFINITIONS}")
-cxx_check_feature ("c++11" "variadic-templates" "N2242" HAVE_CXX11_VARIADIC_TEMPLATES "${ADDITIONAL_DEFINITIONS}")
-cxx_check_feature ("c++11" "initializer-lists"  "N2672" HAVE_CXX11_INITIALIZER_LISTS  "${ADDITIONAL_DEFINITIONS}")
-
 # =======================================================
 # Starting the actual project definition
 
Index: kactivitymanagerd-5.10.5/src/kactivities-features.h.cmake
===================================================================
--- kactivitymanagerd-5.10.5.orig/src/kactivities-features.h.cmake
+++ kactivitymanagerd-5.10.5/src/kactivities-features.h.cmake
@@ -8,10 +8,4 @@
 
 #cmakedefine KAMD_INSTALL_PREFIX "@KAMD_INSTALL_PREFIX@"
 
-#cmakedefine01 HAVE_CXX11_AUTO
-#cmakedefine01 HAVE_CXX11_NULLPTR
-#cmakedefine01 HAVE_CXX11_LAMBDA
-#cmakedefine01 HAVE_CXX11_OVERRIDE
-#cmakedefine01 HAVE_CXX_OVERRIDE_ATTR
-
 #endif

--- End Message ---
--- Begin Message --- 
Source: kactivitymanagerd
Source-Version: 5.19.4-1

In data giovedì 18 gennaio 2018 16:38:54 CET, Helmut Grohne ha scritto:
> Source: kactivitymanagerd
> Version: 5.10.5-2
> Tags: patch upstream
> User: helmutg@debian.org
> Usertags: rebootstrap
> 
> kactivitymanagerd fails to cross build from source, because it checks
> for standard C++11 features (such as auto) with try_run. The build
> doesn't depend on these check results in any way and the upstream source
> pretty much assumes working auto. Thus these checks do not add any
> value. After removing them, kactivitymanagerd cross builds successfully.
> Please consider applying the attached patch.

This was fixed upstream by bumping the requirement to C++17, and thus
removing all the C++ feature checks. This was done with commit
93d81bd0566 [1], which is included in kactivitymanaged >= 5.18.90.
Hence, closing with the first version available in Debian after that.

[1] https://invent.kde.org/plasma/kactivitymanagerd/-/commit/93d81bd056618fb6e20e5c8bcda0310e8342d9fb

-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---
Reply to: