--- Begin Message ---
Package: kiten
Version: 4:20.04.3-1
Severity: important
Tags: patch
kiten invariably segfaults on startup for me:
#0 0x00007f3833a898ff in KConfigBase::hasGroup (this=0x0,
group=group@entry=0x561e19ce44a3 "app") at ./src/core/kconfigbase.cpp:22
#1 0x0000561e19cd660a in Kiten::finishInit (this=0x561e1b286560)
at ./app/kiten.cpp:297
This is due to KConfigGui::sessionConfig() no longer creating a session
config when the application is not actually being restored from an
earlier session, and returning nullptr instead. Hence the segfault.
Patch attached.
-- System Information:
Debian Release: bullseye/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (100, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 5.7.0-2-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages kiten depends on:
ii edict 2020.07.01-1
ii fonts-ipafont-gothic [fonts-japanese-gothic] 00303-21
ii fonts-kanjistrokeorders 4.003~dfsg-1
ii kanjidic 2020.06.29-1
ii kio 5.74.0-2
ii libc6 2.31-4
ii libkf5archive5 5.74.0-2
ii libkf5completion5 5.74.0-2
ii libkf5configcore5 5.74.0-2
ii libkf5configgui5 5.74.0-2
ii libkf5configwidgets5 5.74.0-2
ii libkf5coreaddons5 5.74.0-2
ii libkf5crash5 5.74.0-2
ii libkf5i18n5 5.74.0-3
ii libkf5kiocore5 5.74.0-2
ii libkf5notifications5 5.74.0-2
ii libkf5widgetsaddons5 5.74.0-3
ii libkf5xmlgui5 5.74.0-2+b1
ii libqt5core5a 5.15.1+dfsg-2
ii libqt5dbus5 5.15.1+dfsg-2
ii libqt5gui5 5.15.1+dfsg-2
ii libqt5widgets5 5.15.1+dfsg-2
ii libstdc++6 10.2.0-16
kiten recommends no packages.
Versions of packages kiten suggests:
pn khelpcenter <none>
-- no debconf information
From 7b97ea2ba1eca291d313b92421c76eb07d0c9251 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Bri=C3=A8re?= <fbriere@fbriere.net>
Date: Tue, 10 Nov 2020 08:17:12 -0500
Subject: [PATCH] Check the return value of KConfigGui::sessionConfig() for
nullptr
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
KConfigGui::sessionConfig() no longer creates a session config when the
application is not actually being restored from an earlier session.¹ In
this case, it will now return a null pointer, so we need to check for
that to avoid a segfault.
¹ See commit KDE/kconfig@23d4f14601fd8ff5ca7f28b0ad245ec1935799b2
---
app/kiten.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/kiten.cpp b/app/kiten.cpp
index b6f577a..1ff9d0d 100644
--- a/app/kiten.cpp
+++ b/app/kiten.cpp
@@ -294,7 +294,8 @@ void Kiten::finishInit()
// the app group won't exist and we show demo
if ( _config->initialSearch() )
{
- if ( ! KConfigGui::sessionConfig()->hasGroup( "app" ) )
+ KConfig *config = KConfigGui::sessionConfig();
+ if ( config && ! config->hasGroup( "app" ) )
{
searchTextAndRaise( QStringLiteral( "辞書" ) );
//Note to future tinkerers... DO NOT EDIT OR TRANSLATE THAT
--
2.28.0
--- End Message ---
--- Begin Message ---
Source: kiten
Source-Version: 4:20.08.3-1
Done: Pino Toscano <pino@debian.org>
We believe that the bug you reported is fixed in the latest version of
kiten, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 974597@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Pino Toscano <pino@debian.org> (supplier of updated kiten package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 12 Nov 2020 22:35:01 +0100
Source: kiten
Architecture: source
Version: 4:20.08.3-1
Distribution: unstable
Urgency: medium
Maintainer: Debian/Kubuntu Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Pino Toscano <pino@debian.org>
Closes: 974597
Changes:
kiten (4:20.08.3-1) unstable; urgency=medium
.
* New upstream release:
- fixes a potential crash in sessionConfig. (Closes: #974597)
* Bump the debhelper compatibility to 13:
- switch the debhelper-compat build dependency to 13
* Re-export upstream signing key without extra signatures.
* Set field Upstream-Contact in debian/copyright.
* Remove obsolete fields Contact, Name from debian/upstream/metadata (already
present in machine-readable debian/copyright).
Checksums-Sha1:
f894768e50aecd14bda5f3fa4d6fd91b6bf56a43 2678 kiten_20.08.3-1.dsc
0989ac12d3748dba16f087a0dde52007f13eb387 11299328 kiten_20.08.3.orig.tar.xz
e7b9b652a4b7f91b536d127b74fd29bc8fd2ca60 488 kiten_20.08.3.orig.tar.xz.asc
ecccd186fa226dd3d49d8e629b6cc7397625f377 15112 kiten_20.08.3-1.debian.tar.xz
1039e3a1b04dfcfb8b8164948077f204f0cfd211 18988 kiten_20.08.3-1_source.buildinfo
Checksums-Sha256:
5b2399ff98b17ded0bbda4e4ee6c5bd5c8a61ac8e9c1374033fbad3186920abf 2678 kiten_20.08.3-1.dsc
8c62bd0382141b4742dd6dca8e0e3565c8a61fb98b225a8813da50f60cc23559 11299328 kiten_20.08.3.orig.tar.xz
efca7217f2fb48d0c43478d4d9a93d9c4e50003fafe251f1e2c593c1432e2ab8 488 kiten_20.08.3.orig.tar.xz.asc
0bf88f7c25e137292c9acc51b86a8240c26884e62f24e0eca979406a2636532d 15112 kiten_20.08.3-1.debian.tar.xz
0c6c2fe6630fda7b027d22d3615fd7c9e324d1fb4685698aadd28cce1fc49508 18988 kiten_20.08.3-1_source.buildinfo
Files:
51cb44d784a2f38556ff09e125af0593 2678 kde optional kiten_20.08.3-1.dsc
4114624cba31be073d7b8ec2a77954d7 11299328 kde optional kiten_20.08.3.orig.tar.xz
b872f7713c16b75574e2beeec632942c 488 kde optional kiten_20.08.3.orig.tar.xz.asc
62e9791f5502c61158ac29ae14a6e501 15112 kde optional kiten_20.08.3-1.debian.tar.xz
1419f5548b9a4df0a8bf1969e30cdc30 18988 kde optional kiten_20.08.3-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEXyqfuC+mweEHcAcHLRkciEOxP00FAl+tqr4ACgkQLRkciEOx
P00NFA//ZwOB5KvCEVR+pU/CtAbWBhBATkkMQBDn31gG/aaNDrZCvUOFHzDNONBG
Rvg2IE3ZiJG4qGGqe2nGHb18ZMX2ZtFXvnQlJTKVw/Wan5U/FABhjCxT3Pb5Kn64
EmTvw6ddH2H0EDi243qc9D/MsP/2P2RIEo4z4t8pqvnubst3tbG2efnJrM99JrI9
OWr+kswVhMcYdalFcedGzf9S1E11Xyk4/r7j7McAwoluVbJ6KbCeQ+mmROTGcUCi
J89V8tvVi32g0esfhhvyDLJMMHE7QStl4vSb6UPuWvdxb9V7MldIyIHlwgVNFq02
Yrn40ghyHT0DgfiiOYg7ORJLkWLymoStmewez+7RHXTfuLK8ZCn77iqISbisNlfU
1kA9bFSY1S8etBnyxFCmURyOQQXHJirYM4fyIxCfdW+OG5cmHfbTEzlBCZuNLjCF
kLrEGWd+0/S7U6ZvYb2ryUaus6UWDnEXsH5N3P4jewKbtx98jo8r1e9zPwbLFmO+
KTRGgw08nKzScuxgjgbw/gYOMQ55e9Dwqa3okq66LDIgqYlFQQrS4te9vgTiAZ7M
HC+6GRiIED+iP2jGIsZ4JJ2p6zZQl7J22ZnhInTpSoAGpMrgoZdkCgPsCZjjufs1
77eGXVu4izOIH/pVBFndDkVPEDA0a/xtaKOKjQSYxk7BLvGhyD0=
=WicS
-----END PGP SIGNATURE-----
--- End Message ---