[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#918760: marked as done (kpackage should Build-Depends: qttools5-dev)

Your message dated Sun, 23 Aug 2020 14:39:08 +0200
with message-id <2085532.tSmfoqppWV@thyrus>
and subject line Re: Bug#918760: agree on how to find qhelpgenerator
has caused the Debian Bug report #918760,
regarding kpackage should Build-Depends: qttools5-dev
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
918760: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918760
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: qt5-qmake,qttools5-dev-tools,extra-cmake-modules
User: helmutg@debian.org
Usertags: rebootstrap
Control: affects -1 + src:kpackage

kpackage fails to cross build from source and the cause is tricky. We
start our journey on extra-cmake-modules'
/usr/share/ECM/find-modules/FindQHelpGenerator.cmake. That file assumes
that it will find a "qhelpgenerator" executable next to the qmake
executable. The path of qmake is determined using

    get_target_property(_qmake_EXECUTABLE Qt5::qmake LOCATION)

and results in:

    /usr/lib/<hosttriplet>/qt5/bin/qmake

Now, qttools5-dev-tools places qhelpgenerator in

    /usr/lib/qt5/bin/qhelpgenerator
    /usr/lib/<buildtriplet>/qt5/bin/qhelpgenerator

and qtchooser additionally makes it available as:

    /usr/bin/qhelpgenerator

The end result is that qhelpgenerator is not found and that kpackage
fails to cross build.

extra-cmake-modules's assumption on how to find qhelpgenerator is not
presently valid. We'll either have to reinstate the assumption or make
extra-cmake-modules not assume that.

Now I need your input on which package we need to touch.

Helmut

--- End Message ---
--- Begin Message --- 
Source: kpackage
Source-Version: 5.61.0-1
Done: Maximiliano Curia <maxy@debian.org>

In data mercoledì 9 gennaio 2019 16:53:42 CEST, Helmut Grohne ha scritto:
> Control: reassign -1 src:kpackage
> Control: retitle -1 kpackage should Build-Depends: qttools5-dev
> Control: block -1 by 915122
> Control: tags 915122 + upstream fixed-upstream patch
> 
> On Wed, Jan 09, 2019 at 02:48:17PM +0300, Dmitry Shachnev wrote:
> > On Wed, Jan 09, 2019 at 06:24:32AM +0100, Helmut Grohne wrote:
> > > kpackage fails to cross build from source and the cause is tricky. We
> > > start our journey on extra-cmake-modules'
> > > /usr/share/ECM/find-modules/FindQHelpGenerator.cmake. That file assumes
> > > that it will find a "qhelpgenerator" executable next to the qmake
> > > executable. The path of qmake is determined using
> > >
> > >     get_target_property(_qmake_EXECUTABLE Qt5::qmake LOCATION)
> > 
> > That is the fallback code path.
> 
> Oh right.
> 
> > As I said before in #915122, the correct fix is:
> > 
> > - Cherry-picking commit [1] for extra-cmake-modules or updating it to 5.53.0.
> > - Making all affected packages build-depend on qttools5-dev.
> 
> I'm sorry for failing to notice the existing report. I guess I have too
> many open bug reports now and should slow down filing...
> 
> I'm repurposing this bug for adding the dependency to kpackage.

kpackage was fixed with version 5.61.0-1, hence closing.

Thanks,
-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---
Reply to: