[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Mapbox GL plugin in QtLocation package



Hi!

El vie., 31 may. 2019 16:19, rinigus <rinigus.git@gmail.com> escribió:
Hi Dmitry and Lisandro:

MapboxGL included into QtLocation is a special branch of that library: https://github.com/mapbox/mapbox-gl-native/tree/qt-staging . Let's keep that in mind during the discussion related to QtLocation, but we can extend it to the master branch as well, if needed.

So a special branch. Why that? For me it's just one more reason to keep stuff like it is, or ask someone to package mapbox.


Re JSON license: From the code I in the master and qt-staging branch, I was able to find only one reference to the code from JSON.org and it was JSON checker included via https://github.com/Tencent/rapidjson as a submodule. Regarding that code there is a statement in the LICENSE specifying that it is only in https://github.com/Tencent/rapidjson/tree/master/bin/jsonchecker and can be skipped if not used. I wonder how to handle that case specifically, you probably know the coarse of action regarding it well.

In addition, in qt-staging, rapidjson is not used, as far as I know. All corresponding functionality should be provided via Qt, as in https://github.com/mapbox/mapbox-gl-native/tree/qt-staging/platform/qt

Re bundled software: from looking into https://github.com/mapbox/mapbox-gl-native/tree/qt-staging, it is clear that there are no more submodules in use. It seems that only https://github.com/mapbox/mapbox-gl-native/tree/qt-staging/vendor/nunicode is included as a third-party code. 


If we package qmapboxgl separately, is it known how to bundle it with QtLocation that way that it can be loaded as a module?

It probably needs to be worked out, but definitely preferred over embedding.

My interest stems from the fact that I use MapboxGL for rendering of the maps in Pure Maps (https://github.com/rinigus/pure-maps). Ironically, I am not using QtLocation plugin for it, but QMapboxGL directly through its unofficial QML bindings (ttps://github.com/rinigus/mapbox-gl-qml). This started for historical reasons (Sailfish has still rather old Qt which doesn't include MapboxGL) and seems to be continued since the unofficial bindings are quite convenient to use. There is also at least one aspect that is missing in official bindings that I use.

So, in this respect having QMapboxGL separate and linked to QtLocation would be great. Then I could ask for help to get mapbox-gl-qml packaged as well to make the way for Pure Maps in Debian :)

Considering the size of mapbox I strongly think it should be packaged separately, with a dedicated maintainer.

Reply to: