[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#915319: kde-runtime FTBFS with samba 4.9



Hi Giovanni,

On Sat, Mar 30, 2019 at 07:10:40PM +0100, Giovanni Mascellani wrote:
> I did some further diagnosis on this bug: the reason why CMake fails to
> discover libsmbclient is because CMake tries to compile a little program
> including libsmbclient.h using -std=c90, which is insufficient for
> libsmbclient.h. However libsmbclient.h works with more recent C
> standards, like the GCC default -std=gnu11.
> 
> The attached patch should fix the problem. I can NMU if this is ok for
> you. Probably it is not the cleanest solution ever (if would be better
> to fix CMake files from kdelibs5-dev), but it seems to work.

I would suggest you upload this NMU. If this isn't the right fix, it can
always be reverted.

Thanks,

Ivo


Reply to: