user debian-release@lists.debian.org usertags 915319 + bsp-2019-03-fr-paris tags 915319 + patch thank you Hi, I did some further diagnosis on this bug: the reason why CMake fails to discover libsmbclient is because CMake tries to compile a little program including libsmbclient.h using -std=c90, which is insufficient for libsmbclient.h. However libsmbclient.h works with more recent C standards, like the GCC default -std=gnu11. The attached patch should fix the problem. I can NMU if this is ok for you. Probably it is not the cleanest solution ever (if would be better to fix CMake files from kdelibs5-dev), but it seems to work. Thanks, Giovanni. -- Giovanni Mascellani <g.mascellani@gmail.com> Postdoc researcher - Université Libre de Bruxelles
From 5acb1dc95b67b14d9939ec54135c06b132996776 Mon Sep 17 00:00:00 2001 From: Giovanni Mascellani <gio@debian.org> Date: Sat, 30 Mar 2019 18:59:00 +0100 Subject: [PATCH] Fix libsmbclient.h discovery. --- debian/changelog | 9 +++++++++ debian/rules | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/debian/changelog b/debian/changelog index 60e7c0d..29b52fc 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,12 @@ +kde-runtime (4:17.08.3-2.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * Force usage of -std=gnu11 for CMake compilation, because CMake's default + seems to be -std=c90 which makes libsmbclient.h discovery fail + (closes: #915319). + + -- Giovanni Mascellani <gio@debian.org> Sat, 30 Mar 2019 19:03:11 +0100 + kde-runtime (4:17.08.3-2) unstable; urgency=medium * Team upload. diff --git a/debian/rules b/debian/rules index a581bcd..25cc39a 100755 --- a/debian/rules +++ b/debian/rules @@ -4,7 +4,7 @@ include /usr/share/pkg-kde-tools/qt-kde-team/2/debian-qt-kde.mk include /usr/share/dpkg/architecture.mk override_dh_auto_configure: - $(overridden_command) -- -DBUILD_khelpcenter=FALSE -DBUILD_drkonqi=FALSE + $(overridden_command) -- -DBUILD_khelpcenter=FALSE -DBUILD_drkonqi=FALSE -DCMAKE_REQUIRED_FLAGS="-std=gnu11" override_dh_auto_test: # Disable dh_auto_test at build time -- 2.20.1
Attachment:
signature.asc
Description: OpenPGP digital signature