[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#905736: marked as done (pkg-kde-tools: dh_qmlcdeps fails to process all packages)

Your message dated Sun, 24 Mar 2019 10:34:05 +0000
with message-id <E1h80S5-0002Q6-V3@fasolo.debian.org>
and subject line Bug#905736: fixed in pkg-kde-tools 0.15.29
has caused the Debian Bug report #905736,
regarding pkg-kde-tools: dh_qmlcdeps fails to process all packages
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
905736: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=905736
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: pkg-kde-tools
Version: 0.15.29
Severity: important
Tags: patch

Hi,

while making local backports of Qt5 for Debian stable, I noticed the
following messages in one of the build logs (the one for
qtquickcontrol2-opensource-src to be precise):

------------------
dpkg-gencontrol: warning: Depends field of package qml-module-qtquick-controls2: unknown substitution variable ${qmlc:Depends}
dpkg-gencontrol: warning: Depends field of package qml-module-qtquick-controls2: unknown substitution variable ${qmlc:Depends}
dpkg-gencontrol: warning: Depends field of package qml-module-qt-labs-calendar: unknown substitution variable ${qmlc:Depends}
dpkg-gencontrol: warning: Depends field of package qml-module-qt-labs-calendar: unknown substitution variable ${qmlc:Depends}
------------------

Checking against the logs from the Debian buildds showed that they were
also present there, so it wasn't just an artifact of my backporting.
What was strange about the messages was that the package in question
actually contains .qmlc files and correctly calls dh_qmlcdeps, so the
variables really should have been set.

Further investigation showed that there is a serious bug in dh_qmlcdeps
that makes it stop processing as soon as it encounters the first binary
package without any .qmlc files. Within the main loop over all packages,
right after the find, in line 79 there is a check if any $qt_version_bin
has been found while searching for .qmlc files, and it just exit()s when
there wasn't any:

------------------
    $qt_version_bin or exit(0);
------------------

The attached patch fixes that by just continuing with the next loop
iteration instead of exiting.

What makes this bug important (I actually contemplated calling it
"serious") is that all binary packages built with the buggy dh_qmlcdeps
(the bug existed right from when it was introduced in version 0.15.26)
now potentially contain incorrect dependencies, and might have to be
rebuilt.

Affected packages should all have similar warnings to the above in their
respective build logs though, so there might be some way to check for
packages needing a rebuild. I don't know enough about the buildd
infrastructure, so I can't tell if there's a way to do what's
essentially a large-scale grep across all build logs.

Regards,
Andreas Ferber

>From c19dca9669ec21358793c38699be95cb528fe0a6 Mon Sep 17 00:00:00 2001
From: Andreas Ferber <af+debian-bugregports@chaos-agency.de>
Date: Wed, 8 Aug 2018 20:44:44 +0200
Subject: [PATCH] dh_qmlcdeps: don't exit on first package without qmlc files.

---
 dh_qmlcdeps | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dh_qmlcdeps b/dh_qmlcdeps
index 0b86df4..59b2de6 100755
--- a/dh_qmlcdeps
+++ b/dh_qmlcdeps
@@ -75,7 +75,7 @@ foreach my $package (@{$dh{DOPACKAGES}}) {
         }
     }, $tmpdir);
 
-    $qt_version_bin or exit(0);
+    $qt_version_bin or next;
     my @qt_version = unpack("C4", $qt_version_bin);
     my $qt_version_str = "$qt_version[2].$qt_version[1].$qt_version[0]";
     $qt_version[2] == 5 or error("Qt version $qt_version_str is not supported");
-- 
2.11.0

--- End Message ---
--- Begin Message --- 
Source: pkg-kde-tools
Source-Version: 0.15.29

We believe that the bug you reported is fixed in the latest version of
pkg-kde-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 905736@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dmitry Shachnev <mitya57@debian.org> (supplier of updated pkg-kde-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 24 Mar 2019 13:19:34 +0300
Source: pkg-kde-tools
Architecture: source
Version: 0.15.29
Distribution: unstable
Urgency: medium
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Dmitry Shachnev <mitya57@debian.org>
Closes: 905736 905845
Changes:
 pkg-kde-tools (0.15.29) unstable; urgency=medium
 .
   [ Kunal Mehta ]
   * Replace broken alioth URLs in man pages (Closes: #905845).
 .
   [ Simon Quigley ]
   * Bump Standards-version to 4.1.4, no changes needed.
   * Run wrap-and-sort.
 .
   [ Dmitry Shachnev ]
   * Update Vcs fields for move to salsa.debian.org.
 .
   [ Andreas Ferber ]
   * dh_qmlcdeps: don't exit on first package without qmlc files (Closes:
     #905736).
Checksums-Sha1:
 00b3ec020834c8db57b6010ae7ffb18c1c5d74b2 2053 pkg-kde-tools_0.15.29.dsc
 faa1df241c61831914f8de3849332438b6f0acf1 99476 pkg-kde-tools_0.15.29.tar.xz
 d301d35e2b3a8d3390e3ac16da7c2c5490535c9c 6594 pkg-kde-tools_0.15.29_source.buildinfo
Checksums-Sha256:
 495c218bfc6c4b0359c27833326f2797ef42fa5cbf546ceb4ad65fd51906bb7d 2053 pkg-kde-tools_0.15.29.dsc
 bd843ac671fe500b3bcd9f0336c53874a01dab0deec339a51bc0172fa6151d02 99476 pkg-kde-tools_0.15.29.tar.xz
 a5b03684053d3b0f8507a90bfae3eac5ad8f23b10f5ab2960e52d15eeb3e4d61 6594 pkg-kde-tools_0.15.29_source.buildinfo
Files:
 314d0d3775007071e25b5e422dae99b2 2053 devel optional pkg-kde-tools_0.15.29.dsc
 17941f5e98ba1c44fafbf5eebe19d114 99476 devel optional pkg-kde-tools_0.15.29.tar.xz
 8d8f0c6ea6b266c20c8e9aa233b7ca69 6594 devel optional pkg-kde-tools_0.15.29_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEE8kKZ/xu8kBi5BqTLYCaTbS8ciuAFAlyXWiITHG1pdHlhNTdA
ZGViaWFuLm9yZwAKCRBgJpNtLxyK4GtZEACLzeO7gHS8zdWq0bIZa2OzRzDHqk9F
jQ1Dn3tvQS3Y7VYUtcCApjf2jxVf6CAVj0rigLqLfgguKZSiPC7chdkrng0YLQ8m
m4sr4vPR9gUn9ZobGms7ttLd6F3iQMSXy8Rlvu+pN2CEBExuvNPmvak24PrDspE2
W7zmtaBbT6csjk8YKtKF1K1i41MPoWkTcIYhQYjRAPEMRMz0bPSHC00xOsQzhBjW
HzXRbo4KfME382aBUjg6oZJ6m5wIB09X/W9smT5WJmhU/62r7mv7AVVPxkHHzDEQ
H5UIjBnG9Fm/iNVYOdfp40cZKCmbHZ7k1vlqu63skH3nfEhGFmlBHMtpmwvzY98U
I6BDxvZVS3rnem8F2FOjqixmb1ZV5Q7wKq6+LK6P1uJVuCMaDmayWvt255ADn80F
BSMjnRvi8YfLJB8nEz3/8AypmJc7k/wkwIocnoTxfVryxycOH7r6ko8dClQVEcsR
9uUJyAY+i0DJfUpnUOTduoClEoI8+dud/rI7vrLW0ppGaJEKGF8Fcz7S6S3h9o+w
Nya7LRuI7PqijhreWPJV4HdpawcHw65pxeGFC8QjfXA1KB4KhCqYXtvufYVkMfsX
aSU2JLhrTPwyO7llCTcSQv3fLk1IGRoC8EEwrUVp0WAD9nC8h6AdTBdewxKwsKQu
xmyJY9w0HNYhwg==
=TF/Q
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: