On Fri, Nov 23, 2018 at 10:07:47AM -0300, Lisandro Damián Nicanor Pérez Meyer wrote:
> Hi Julian!
>
> El jueves, 22 de noviembre de 2018 21:54:30 -03 Julian Gilbey escribió:
> > On Sun, Nov 18, 2018 at 03:35:11PM +0000, Julian Gilbey wrote:
> > > On Sun, Nov 18, 2018 at 09:01:19AM -0300, Lisandro Damián Nicanor Pérez
> Meyer wrote:
> > > > Yesterday I've uploaded qtbase with this fix, please try it.
> > >
> > > Excellent, thanks! I just built it on my testing machine, and it
> > > worked perfectly with the Python script in this bug report and the
> > > simplebrowser example.
> >
> > Hi Lisandro,
> >
> > Upstream have now patched what-I-presume-will-become 5.12.1 with
> > almost this patch. But it's gone through several iterations, and now
> > the patch also deletes a couple of #include's. See patch set #7 at
> > https://codereview.qt-project.org/#/c/245294/
> >
> > I doubt it's worth uploading a new version just for this, but when you
> > are doing the next qtbase upload, you might consider making this
> > change.
>
> That's exactly the patch with which I closed this bug. This is already in the
> archive. Enjoy!
Hi Lisandro,
Version 7 of the patch is slightly different from the one you applied
to the archive: it also removes some conditional #includes. But it is
probably unimportant for Debian.
Thank you for the clarification. Dmitry made me note the same thing, and yes, is unimportant.