[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#907013: marked as done (calligra FTBFS, missing QT includes.)

Your message dated Wed, 05 Sep 2018 07:04:16 +0000
with message-id <E1fxRrM-000CLb-83@fasolo.debian.org>
and subject line Bug#907013: fixed in calligra 1:3.1.0+dfsg-3
has caused the Debian Bug report #907013,
regarding calligra FTBFS, missing QT includes.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
907013: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907013
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: calligra
Version: 3.1.0+dfsg-2
Severity: serious
Tags: patch

Looks like calligra recently started to FTBFS, I first saw this in raspbian but it is also happening on the reproducible builds test infrastructure, so it's not raspbian specific.

http://buildd.raspbian.org/status/fetch.php?pkg=calligra&arch=armhf&ver=1%3A3.1.0%2Bdfsg-2%2Bb5&stamp=1534965502
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/calligra.html


/<<BUILDDIR>>/calligra-3.1.0+dfsg/libs/widgets/KoPageLayoutWidget.cpp:157:33: error: invalid use of incomplete type 'class QButtonGroup'
      Q_ASSERT(d->orientationGroup->button( layout.orientation ));
                                  ^~
In file included from /usr/include/arm-linux-gnueabihf/qt5/QtWidgets/qradiobutton.h:44,
                  from /usr/include/arm-linux-gnueabihf/qt5/QtWidgets/QRadioButton:1,
                  from /<<BUILDDIR>>/calligra-3.1.0+dfsg/obj-arm-linux-gnueabihf/libs/widgets/ui_KoPageLayoutWidget.h:22,
                  from /<<BUILDDIR>>/calligra-3.1.0+dfsg/libs/widgets/KoPageLayoutWidget.cpp:22:
/usr/include/arm-linux-gnueabihf/qt5/QtWidgets/qabstractbutton.h:53:7: note: forward declaration of 'class QButtonGroup'
  class QButtonGroup;


I presume this was triggered by a new version of one or more qt libraries.

The FTBFS can be fixed by explicitly adding includes for the incomplete types.

Debdiff attatched, no intent to NMU.


diff -Nru calligra-3.1.0+dfsg/debian/changelog calligra-3.1.0+dfsg/debian/changelog
--- calligra-3.1.0+dfsg/debian/changelog	2018-03-09 08:37:57.000000000 +0000
+++ calligra-3.1.0+dfsg/debian/changelog	2018-08-22 20:34:52.000000000 +0000
@@ -1,3 +1,9 @@
+calligra (1:3.1.0+dfsg-2+rpi1) buster-staging; urgency=medium
+
+  * Add missing qt includes.
+
+ -- Peter Michael Green <plugwash@raspbian.org>  Wed, 22 Aug 2018 20:34:52 +0000
+
 calligra (1:3.1.0+dfsg-2) unstable; urgency=medium
 
   * Team upload.
diff -Nru calligra-3.1.0+dfsg/debian/patches/add-missing-includes.patch calligra-3.1.0+dfsg/debian/patches/add-missing-includes.patch
--- calligra-3.1.0+dfsg/debian/patches/add-missing-includes.patch	1970-01-01 00:00:00.000000000 +0000
+++ calligra-3.1.0+dfsg/debian/patches/add-missing-includes.patch	2018-08-22 20:34:52.000000000 +0000
@@ -0,0 +1,102 @@
+Description:  Add missing qt includes.
+Author: Peter Michael Green <plugwash@raspbian.org>
+Last-Update: 2018-08-22
+
+Index: calligra-3.1.0+dfsg/libs/widgets/KoPageLayoutWidget.cpp
+===================================================================
+--- calligra-3.1.0+dfsg.orig/libs/widgets/KoPageLayoutWidget.cpp
++++ calligra-3.1.0+dfsg/libs/widgets/KoPageLayoutWidget.cpp
+@@ -22,6 +22,7 @@
+ #include <ui_KoPageLayoutWidget.h>
+ 
+ #include <KoUnit.h>
++#include <QButtonGroup>
+ 
+ class Q_DECL_HIDDEN KoPageLayoutWidget::Private
+ {
+Index: calligra-3.1.0+dfsg/libs/widgets/KoCsvImportDialog.cpp
+===================================================================
+--- calligra-3.1.0+dfsg.orig/libs/widgets/KoCsvImportDialog.cpp
++++ calligra-3.1.0+dfsg/libs/widgets/KoCsvImportDialog.cpp
+@@ -37,6 +37,8 @@
+ 
+ #include "ui_KoCsvImportDialog.h"
+ 
++#include <QButtonGroup>
++
+ class KoCsvImportWidget : public QWidget, public Ui::KoCsvImportWidget
+ {
+ Q_OBJECT
+Index: calligra-3.1.0+dfsg/plugins/chartshape/dialogs/TableEditorDialog.cpp
+===================================================================
+--- calligra-3.1.0+dfsg.orig/plugins/chartshape/dialogs/TableEditorDialog.cpp
++++ calligra-3.1.0+dfsg/plugins/chartshape/dialogs/TableEditorDialog.cpp
+@@ -33,6 +33,7 @@
+ #include "ChartTableView.h"
+ #include "ChartDebug.h"
+ 
++#include <QAction>
+ 
+ using namespace KoChart;
+ 
+Index: calligra-3.1.0+dfsg/words/part/dialogs/KWRunAroundProperties.cpp
+===================================================================
+--- calligra-3.1.0+dfsg.orig/words/part/dialogs/KWRunAroundProperties.cpp
++++ calligra-3.1.0+dfsg/words/part/dialogs/KWRunAroundProperties.cpp
+@@ -28,6 +28,8 @@
+ 
+ #include <kundo2command.h>
+ 
++#include <QButtonGroup>
++
+ KWRunAroundProperties::KWRunAroundProperties(FrameConfigSharedState *state)
+         : m_state(state)
+ {
+Index: calligra-3.1.0+dfsg/words/part/dialogs/KWAnchoringProperties.cpp
+===================================================================
+--- calligra-3.1.0+dfsg.orig/words/part/dialogs/KWAnchoringProperties.cpp
++++ calligra-3.1.0+dfsg/words/part/dialogs/KWAnchoringProperties.cpp
+@@ -36,6 +36,7 @@
+ #include <kundo2command.h>
+ 
+ #include <QComboBox>
++#include <QButtonGroup>
+ 
+ const int KWAnchoringProperties::vertRels[4][20] = {
+     { // KoShapeAnchor::AnchorAsCharacter
+Index: calligra-3.1.0+dfsg/plugins/formulashape/FormulaToolWidget.cpp
+===================================================================
+--- calligra-3.1.0+dfsg.orig/plugins/formulashape/FormulaToolWidget.cpp
++++ calligra-3.1.0+dfsg/plugins/formulashape/FormulaToolWidget.cpp
+@@ -31,6 +31,7 @@
+ #include <QTableWidget>
+ #include <QAction>
+ #include <QMenu>
++#include <QHeaderView>
+ 
+ FormulaToolWidget::FormulaToolWidget( KoFormulaTool* tool, QWidget* parent )
+                   : QTabWidget( parent )
+Index: calligra-3.1.0+dfsg/stage/part/KPrPresentationTool.cpp
+===================================================================
+--- calligra-3.1.0+dfsg.orig/stage/part/KPrPresentationTool.cpp
++++ calligra-3.1.0+dfsg/stage/part/KPrPresentationTool.cpp
+@@ -32,6 +32,7 @@
+ #include <QDesktopServices>
+ #include <QUrl>
+ #include <QDBusConnection>
++#include <QFrame>
+ 
+ #include <KoShape.h>
+ #include <KoShapeManager.h>
+Index: calligra-3.1.0+dfsg/sheets/dialogs/LayoutDialog.cpp
+===================================================================
+--- calligra-3.1.0+dfsg.orig/sheets/dialogs/LayoutDialog.cpp
++++ calligra-3.1.0+dfsg/sheets/dialogs/LayoutDialog.cpp
+@@ -49,6 +49,7 @@
+ #include <QGridLayout>
+ #include <QPixmap>
+ #include <QSpinBox>
++#include <QButtonGroup>
+ 
+ #include <kcolorbutton.h>
+ #include <kcombobox.h>
diff -Nru calligra-3.1.0+dfsg/debian/patches/series calligra-3.1.0+dfsg/debian/patches/series
--- calligra-3.1.0+dfsg/debian/patches/series	1970-01-01 00:00:00.000000000 +0000
+++ calligra-3.1.0+dfsg/debian/patches/series	2018-08-22 20:34:52.000000000 +0000
@@ -0,0 +1 @@
+add-missing-includes.patch

--- End Message ---
--- Begin Message --- 
Source: calligra
Source-Version: 1:3.1.0+dfsg-3

We believe that the bug you reported is fixed in the latest version of
calligra, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 907013@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Pino Toscano <pino@debian.org> (supplier of updated calligra package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 05 Sep 2018 08:39:20 +0200
Source: calligra
Binary: calligra karbon calligra-reports-web-element calligrasheets calligrasheets-data calligrawords calligrawords-data calligrastage calligrastage-data calligra-libs calligra-data okular-backend-odp okular-backend-odt calligra-gemini calligra-gemini-data calligra-l10n-bs calligra-l10n-ca calligra-l10n-cavalencia calligra-l10n-cs calligra-l10n-da calligra-l10n-de calligra-l10n-el calligra-l10n-engb calligra-l10n-es calligra-l10n-et calligra-l10n-fi calligra-l10n-fr calligra-l10n-gl calligra-l10n-hu calligra-l10n-it calligra-l10n-ja calligra-l10n-kk calligra-l10n-nb calligra-l10n-nl calligra-l10n-pl calligra-l10n-pt calligra-l10n-ptbr calligra-l10n-ru calligra-l10n-sk calligra-l10n-sv calligra-l10n-tr calligra-l10n-uk calligra-l10n-zhcn calligra-l10n-zhtw
Architecture: source
Version: 1:3.1.0+dfsg-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Pino Toscano <pino@debian.org>
Description:
 calligra   - extensive productivity and creative suite
 calligra-data - common shared data for the Calligra Suite
 calligra-gemini - unified interface for stage and words
 calligra-gemini-data - Calligra Gemini - data files
 calligra-l10n-bs - dummy empty package
 calligra-l10n-ca - dummy empty package
 calligra-l10n-cavalencia - dummy empty package
 calligra-l10n-cs - dummy empty package
 calligra-l10n-da - dummy empty package
 calligra-l10n-de - dummy empty package
 calligra-l10n-el - dummy empty package
 calligra-l10n-engb - dummy empty package
 calligra-l10n-es - dummy empty package
 calligra-l10n-et - dummy empty package
 calligra-l10n-fi - dummy empty package
 calligra-l10n-fr - dummy empty package
 calligra-l10n-gl - dummy empty package
 calligra-l10n-hu - dummy empty package
 calligra-l10n-it - dummy empty package
 calligra-l10n-ja - dummy empty package
 calligra-l10n-kk - dummy empty package
 calligra-l10n-nb - dummy empty package
 calligra-l10n-nl - dummy empty package
 calligra-l10n-pl - dummy empty package
 calligra-l10n-pt - dummy empty package
 calligra-l10n-ptbr - dummy empty package
 calligra-l10n-ru - dummy empty package
 calligra-l10n-sk - dummy empty package
 calligra-l10n-sv - dummy empty package
 calligra-l10n-tr - dummy empty package
 calligra-l10n-uk - dummy empty package
 calligra-l10n-zhcn - dummy empty package
 calligra-l10n-zhtw - dummy empty package
 calligra-libs - common libraries and binaries for the Calligra Suite
 calligra-reports-web-element - transitional dummy package for libkreport3-plugin-web
 calligrasheets - spreadsheet for the Calligra Suite
 calligrasheets-data - data files for Sheets spreadsheet
 calligrastage - presentation program for the Calligra Suite
 calligrastage-data - data files for Calligra Stage
 calligrawords - word processor for the Calligra Suite
 calligrawords-data - data files for Words word processor
 karbon     - vector graphics application for the Calligra Suite
 okular-backend-odp - Okular backend for ODP documents
 okular-backend-odt - Okular backend for ODT documents
Closes: 907013
Changes:
 calligra (1:3.1.0+dfsg-3) unstable; urgency=medium
 .
   * Team upload.
   * Update Vcs-* fields.
   * Bump Standards-Version to 4.2.1, no changes required.
   * Update few things in README.source.
   * Backport upstream commits a7ebecb9fbee2190e649c44ed53f1299013baa30, and
     ee83e0f2c251072e47a2799619cdc79efe67e651 to fix build with Qt >= 5.11;
     patches upstream_Fix-build-with-Qt-5.11-missing-headers.patch, and
     upstream_Fix-compilation-with-Qt-5.11-missing-include.patch.
     (Closes: #907013)
Checksums-Sha1:
 e83d7dd1d2b5e975d159aca25c6536a4cd22eb32 6671 calligra_3.1.0+dfsg-3.dsc
 94a2faad8811502f180d75c93e4059a84993240a 38144 calligra_3.1.0+dfsg-3.debian.tar.xz
 91ef71b013b4b546194046ce22f47ff393580e20 27003 calligra_3.1.0+dfsg-3_source.buildinfo
Checksums-Sha256:
 67bb11899b18a8905f2f08305276e52589f160ebf4981af4e7d2378f4196c233 6671 calligra_3.1.0+dfsg-3.dsc
 6f2ec69d1abcf2085a7704e1d8589a88564b521198345a3bb7255c1fed3a8c92 38144 calligra_3.1.0+dfsg-3.debian.tar.xz
 cb44840ccc35caccb5ea1caf71b3a3ae42a5386137891096191d15b30d3d07b1 27003 calligra_3.1.0+dfsg-3_source.buildinfo
Files:
 f70ffbd37e89fa0d251d604ef57d4604 6671 kde optional calligra_3.1.0+dfsg-3.dsc
 41611ae0965ba253dc72aa58cca37f20 38144 kde optional calligra_3.1.0+dfsg-3.debian.tar.xz
 ffcfe404b5f5e3e0c93c24769e842193 27003 kde optional calligra_3.1.0+dfsg-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEXyqfuC+mweEHcAcHLRkciEOxP00FAluPel0ACgkQLRkciEOx
P02B/RAAn5rR5USFeHNj5gfrAYyjipw8JYOHdM7XBzYU0qib5Ve45j2nmTIfXboI
cfcChd7xwYMWjxzvLjJPD+SLXqlPg2e7RfMEN6SaSbwbCb1fI8u2SzxGTIjbxoyk
w8t/oKCjDF0uwofn1XgGDfou3yle1PIrZnOL9H7XG/3XLXSfoRD2BJql6Xwfpet/
tytJEWaTXTrkUTMQyg5kf/GIM7VQXLtEmUVo8PkSy53qOc5RHw6Xrq8RkaqoJF0E
IEesfDe25mEMbYaUBpbPDa+3dn8QKYkvFna7GDXK3vjF+bp2j4GvT1JHpHV7wyRY
FeVBGzxSoLMTh1BtdTPoWdeUZMpyQ2sPxEmxqo4d1Wm0zflsE7CkbiX+iPqpf42s
GSeF9iUnalbv1TPsDAK9KiGtlzot9Z50aSn+QDVl+267Epz81QuCQQ1nQF2jhf3m
KrYCsjleBCeTrLf669q1qGb/ZAa/Lk1HAr2s9tn+eqpk2YpnuyDdENrAlsuRF468
uc0K56sinPXSryoUQhbJMFfxbfgyNIQqde9I+d4dnCxfDd6ORyqmvRLHQ+uURn8o
fi6riEwVahvpCn0SzC0YgCjS6WlXy067B5gebAjEzTiozZCYi+IpC+724+Ke2QUz
TeVd9gxqosLuSLYP/vBVE4NJUGEm/33I8mN16rhaACgd/xoKn20=
=mDJH
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: