El sábado, 5 de mayo de 2018 10:06:22 -03 Manuel A. Fernandez Montecelo escribió: > 2018-05-05 3:56 GMT+02:00 Lisandro Damián Nicanor Pérez Meyer > > <perezmeyer@gmail.com>: > > I was about to upload qt4 when I found: > > > > -Q_GLOBAL_STATIC_WITH_ARGS(const QString, orgFreedesktopDBusString, > > (QLatin1String(DBUS_SERVICE_DBUS))) +Q_GLOBAL_STATIC_WITH_ARGS(QString, > > orgFreedesktopDBusString, (QLatin1String(DBUS_SERVICE_DBUS))) > > > > This clearly does not looks ok. Probably a mistake? > > I changed this because the compilation fails otherwise: [snip yet another excellent explanation] > The alternative would be to use -fpermissive globally, I think, but > this would mask other similar problems, so I patched that one and it > was the only such problematic line in the whole code. > > > My best guess is that no other [popular] platforms are using "generic" > but its own, so this code is never compiled in Debian for other arches > and thus it doesn't fail, it's a latent error in code of unused > code-paths. Let's check that. I'm currently running getbuildlog and will grep them. But judging for what you wrote above you are probably just right. Right, there seems to be no direct usage. > I somehow prefer to use generic, because there's no point in low-level > porting Qt4 at this point. Worst case scenario: C&P generic to riscv64, fix that line and be done. But yes, let's use this as a last resort, as the fix seems legit. -- "In college, I cooked some hot dogs by putting metal forks in each end of the hot dog and running 120 volts through it. Hot dogs have just enough conductivity so that this works well" greenroom(576281) - on a truly geeky way to cook hot dogs. Posted in Slashdot, also found in The Open Source Cookbook for Geeks. Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/
Attachment:
signature.asc
Description: This is a digitally signed message part.