[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#862883: Port from libnm-glib/libnm-util to libnm



On Wed, 20 Dec 2017 09:58:16 +0100 Lubomir Rintel <lkundrak@v3.sk> wrote:
> This doesn't seem to build with current libnm and glib, perhaps because
> "signals" is a reserved word in MOC?
> 
> Build log:
> >           In file included from /usr/include/qt4/QtCore/qobject.h:47:0,
> >                  from /usr/include/qt4/QtCore/QObject:1,
> >                  from /usr/include/solid/networking.h:25,
> >                  from /home/lkundrak/src/kde-runtime-16.08.3/solid-networkstatus/kded/systemstatusinterface.h:27,
> >                  from /home/lkundrak/src/kde-runtime-16.08.3/solid-networkstatus/kded/networkmanagerstatus.h:27,
> >                  from /home/lkundrak/src/kde-runtime-16.08.3/solid-networkstatus/kded/networkmanagerstatus.cpp:27:
> > /usr/include/glib-2.0/gio/gdbusintrospection.h:155:25: error: expected unqualified-id before ‘protected’
> >    GDBusSignalInfo     **signals;
> >                          ^
> > In file included from /usr/include/glib-2.0/gio/gio.h:54:0,
> >                  from /usr/include/libnm/nm-types.h:24,
> >                  from /usr/include/libnm/nm-object.h:29,
> >                  from /usr/include/libnm/nm-access-point.h:29,
> >                  from /usr/include/libnm/NetworkManager.h:26,
> >                  from /home/lkundrak/src/kde-runtime-16.08.3/solid-networkstatus/kded/networkmanagerstatus.cpp:31:
> > /usr/include/glib-2.0/gio/gdbusintrospection.h:155:24: error: expected ‘;’ at end of member declaration
> >    GDBusSignalInfo     **signals;
> >                         ^
> > /usr/include/glib-2.0/gio/gdbusintrospection.h:155:32: error: expected ‘:’ before ‘;’ token
> >    GDBusSignalInfo     **signals;
> >                                 ^
> > solid-networkstatus/kded/CMakeFiles/kded_networkstatus.dir/build.make:228: recipe for target 'solid-networkstatus/kded/CMakeFiles/kded_networkstatus.dir/networkmanagerstatus.cpp.o' failed
> > 

See
https://bugs.kde.org/show_bug.cgi?id=378109
or
https://git.reviewboard.kde.org/r/123091/

Seems very unfortunate, that gdbusintrospection.h uses that name. Maybe
we could convince glib upstream to rename the variable to make it easier
to use glib/gio from KDE/Qt applications and not having to work around
that invidually.

That said, I'm not really familiar with Qt, so not sure if using
-DQT_NO_KEYWORDS + macros like Q_EMIT are consider a proper solution for
this kind of problem.

KDE maintainers, any suggestions?

Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: