[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#866283: marked as done (python-kde4: maintainer script(s) not using strict mode)

Your message dated Sun, 21 Jan 2018 13:18:39 +0000
with message-id <[🔎] E1edFWB-000H58-0G@fasolo.debian.org>
and subject line Bug#887377: Removed package(s) from unstable
has caused the Debian Bug report #866283,
regarding python-kde4: maintainer script(s) not using strict mode
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
866283: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=866283
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: python-kde4
Version: 4:4.14.3-2
Severity: normal
User: treinen@debian.org
Usertags: colis-shparser

Dear maintainer,

at least one of the maintainer scripts (preinst, postinst, prerm,
postrm) of the package python-kde4 does not use strict mode. Policy
section 10.4 says:

"Shell scripts (sh and bash) [..] should almost certainly start with
set -e so that errors are detected."

"Every script should use set -e or check the exit status of every
command."

Please insert a "set -e" at the beginning of your script to enable
strict mode. You should not replace this by a first line "#!/bin/sh
-e" as it is not effective when your script is executed by an
explicit invocation of sh.

Note that this might make your script fail in cases where it did not
fail before. This is the purpose of strict mode - make it fail when
any unexpected error is encountered. You should make sure that you
catch any error (non-zero exit codes of commands) that you decide to
tolerate. Techniques to locally catch an error include using
appropriate options to your command when available, adding a " ||
true" at the end of the command, or selectively switching off strict
mode by "set +e" and switching it back on again later by "set -e". 

This bug filing has been discussed and approved in thread [1].

-Ralf.

[1] https://lists.debian.org/debian-devel/2017/06/msg00342.html

--- End Message ---
--- Begin Message --- 
Version: 4:4.14.3-4+rm

Dear submitter,

as the package pykde4 has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/887377

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@ftp-master.debian.org.

Debian distribution maintenance software
pp.
Luca Falavigna (the ftpmaster behind the curtain)

--- End Message ---
Reply to: