[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#914045: qtbase-opensource-src breaks lots of autopkgtests



In data domenica 18 novembre 2018 22:08:17 CET, Dmitry Shachnev ha scritto:
> Hi Lisandro and Paul!
> 
> On Sun, Nov 18, 2018 at 05:47:04PM -0300, Lisandro Damián Nicanor Pérez Meyer wrote:
> > None of the qtbase changes should be triggering this. *But* all the packages
> > are being built with qttools5-dev-tools 5.11.2-4 instead of 5.11.2-5, and that
> > might be the issue, as the latest version contains a fix for some clang stuff:
> >
> > <https://bugreports.qt.io/browse/QTBUG-70896>
> >
> > Ideally this tests should be retried with qttools-dev-tools 5.11.2-5. Can that
> > be done? No enough build power here to try myself.
> 
> No, retrying them won’t help.
> 
> (TL;DR: we need to patch extra-cmake-modules. Extended description below.)
> 
> The failures are caused by my commit which was fixing bug #913499:
> 
> https://salsa.debian.org/qt-kde-team/qt/qtbase/commit/44912fe676105951250e2cf5ad6c9bccf21e72cc
> 
> It broke the logic in FindQHelpGenerator.cmake, which was detecting
> qhelpgenerator using the path from location of Qt5::qmake.
> 
> Previously it was correctly detecting it in /usr/lib/qt5/bin/qhelpgenerator,
> but after the above commit it detects it in /usr/bin/qhelpgenerator which
> fails with:
> 
>   qhelpgenerator: could not find a Qt installation of ''
> 
> I see that Pino already fixed this in extra-cmake-modules upstream:
> 
> https://cgit.kde.org/extra-cmake-modules.git/commit/?id=96d169b87292d935
> 
> The best way forward will be to cherry-pick that patch in extra-cmake-modules.

This is correct, but not enough.  The fix of the qhelpgenerator
detection works only when the cmake config module for it is installed,
which is shipped in qttools5-dev.  Sadly, this package is not installed
by all the Frameworks packages that generate QCH documentation, so
uploading extra-cmake-modules with the above commit will do not it
alone.

The additional fix is to add also qttools5-dev as build dependency, and
possibly also limit the documentation building to indep-only builds
(since the QCH files are shipped in arch:any -doc packages).  Imagine
that there are almost 80 sources of Frameworks, and 60 of them provide
a QCH documentation...

-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: