[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#911601: qtdeclarative-opensource-src: use arch-bits=32/64 in symbol file



Control: tags -1 + moreinfo

Hi YunQuiang!

On Mon, Oct 22, 2018 at 08:48:25PM +0800, YunQiang Su wrote:
> Package: src:qtdeclarative-opensource-src
> Version: 5.11.2-2
>
> Please use arch-bits=32/64 in symbol files if applicable.
> For example the newly added:
>
> (arch=!amd64 !arm64 !ia64 !mips64el !ppc64el !riscv64 !sparc64)_ZNK3QV45Value9toIntegerEv@Qt_5_PRIVATE_API 5.11.1 1

Unfortunately this is a bad example. This symbol is missing not on all 64-bit
architectures. Note that it is *not* missing on s390x.

The right thing to do in this case is marking it as (optional=inline|...),
according to the source code:

https://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/qml/jsruntime/qv4value_p.h?h=v5.11.2#n791

> I am working on a new 64bit ports - mips64r6el, the hardcoded list, make it
> some bit chaos for new ports.
>
> If you don't like this scheme, please add mips64r6 mips64r6el to this list.

Can you please attach the build logs or just the dh_makeshlibs output on these
architectures? This way we will be able to automatically update the symbols
files using pkgkde-symbolshelper.

--
Dmitry Shachnev

Attachment: signature.asc
Description: PGP signature


Reply to: