[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#887687: libsmokeqt4-dev: broken symlinks and causes qt4-perl FTBFS



Control: tag -1 patch

On Fri, Jan 19, 2018 at 06:23:25AM +0200, Adrian Bunk wrote:
> Package: libsmokeqt4-dev
> Version: 4:4.14.3-1.2
> Severity: serious
> Control: affects -1 src:qt4-perl
> 
> qt4-perl FTBFS:
> 
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/qt4-perl.html
> 
> ...
> make[3]: *** No rule to make target '/usr/lib/libsmokeqt3support.so', needed by 'blib/arch/auto/Qt3Support4/Qt3Support4.so'.  Stop.
> make[3]: Leaving directory '/build/1st/qt4-perl-4.8.4/obj-x86_64-linux-gnu'
> CMakeFiles/Makefile2:473: recipe for target 'qt3support/src/CMakeFiles/perl_qt3support4.dir/all' failed
> make[2]: *** [qt3support/src/CMakeFiles/perl_qt3support4.dir/all] Error 2
> make[2]: Leaving directory '/build/1st/qt4-perl-4.8.4/obj-x86_64-linux-gnu'
> Makefile:143: recipe for target 'all' failed
> make[1]: *** [all] Error 2
> make[1]: Leaving directory '/build/1st/qt4-perl-4.8.4/obj-x86_64-linux-gnu'
> 
> 
> /usr/lib/libsmokeqt3support.so and several other .so
> links are broken.

I believe the attached patch fixes this, allowing qt4-perl to build
again in my tests.

Please consider applying this as an interim fix even if qt4-perl is
going away, to unblock the Perl 5.28 transition.
-- 
Niko Tyni   ntyni@debian.org
>From 8d0f96e2b91a03476f509d75f6066d29d0124066 Mon Sep 17 00:00:00 2001
From: Niko Tyni <ntyni@debian.org>
Date: Tue, 17 Jul 2018 20:34:05 +0300
Subject: [PATCH] Disable building the libraries that aren't packaged anymore

This removes broken symlinks in libsmokeqt4-dev, making qt4-perl build
again at least for now.

Closes: #887687
---
 CMakeLists.txt | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 440dc3f..1ab7439 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -43,36 +43,17 @@ macro_log_feature(QSCINTILLA_FOUND "QScintilla2" "QScintilla2 libraries" "http:/
 
 set(QTDEFINES_FILE ${CMAKE_CURRENT_BINARY_DIR}/qtdefines)
 
-if(WITH_QT3_SUPPORT)
-    add_definitions(-DQT3_SUPPORT)
-endif(WITH_QT3_SUPPORT)
-
 add_subdirectory(qtcore)
 macro_optional_add_bindings(QT_QTNETWORK_FOUND "QtNetwork" qtnetwork)
-macro_optional_add_bindings(QT_QTDBUS_FOUND "QtDBus" qtdbus)
-macro_optional_add_bindings(QT_QTDECLARATIVE_FOUND "QtDeclarative" qtdeclarative)
 macro_optional_add_bindings(QT_QTGUI_FOUND "QtGui" qtgui)
-macro_optional_add_bindings(QT_QTSVG_FOUND "QtSvg" qtsvg)
-macro_optional_add_bindings(QT_QTSQL_FOUND "QtSql" qtsql)
 macro_optional_add_bindings(QT_QTXML_FOUND "QtXml" qtxml)
-macro_optional_add_bindings(QT_QTXMLPATTERNS_FOUND "QtXmlPatterns" qtxmlpatterns)
-macro_optional_add_bindings(QT_QTOPENGL_FOUND "QtOpenGL" qtopengl)
-macro_optional_add_bindings(QT_QTWEBKIT_FOUND "QtWebKit" qtwebkit)
-macro_optional_add_bindings(QT_QTSCRIPT_FOUND "QtScript" qtscript)
-macro_optional_add_bindings(QT_QTUITOOLS_FOUND "QtUiTools" qtuitools)
 macro_optional_add_bindings(QT_QTTEST_FOUND "QtTest" qttest)
 macro_optional_add_bindings(QT_QTMULTIMEDIA_FOUND "QtMultimedia" qtmultimedia)
-macro_optional_add_bindings(QT_QT3SUPPORT_FOUND "Qt3Support" qt3support)
-macro_optional_add_bindings(QT_QTHELP_FOUND "QtHelp" qthelp)
-
-macro_optional_add_bindings(PHONON_FOUND "Phonon" phonon)
 
 macro_optional_add_bindings(QSCINTILLA_FOUND "QScintilla" qsci)
 
 macro_optional_add_bindings(Qwt5_Qt4_FOUND "Qwt" qwt)
 
-macro_optional_add_bindings(QIMAGEBLITZ_FOUND "QImageBlitz" qimageblitz)
-
 
 
 
-- 
2.18.0


Reply to: