[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#901566: marked as done (qtwebkit: Please add support for architecture "riscv64")

Your message dated Thu, 21 Jun 2018 01:34:24 +0000
with message-id <E1fVoUS-0002EU-Lo@fasolo.debian.org>
and subject line Bug#901566: fixed in qtwebkit 2.3.4.dfsg-10
has caused the Debian Bug report #901566,
regarding qtwebkit: Please add support for architecture "riscv64"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
901566: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901566
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: qtwebkit
Version: 2.3.4.dfsg-9.1
Severity: normal
Tags: patch upstream
User: debian-riscv@lists.debian.org
Usertags: riscv64

Hi,

I know that you want this package removed soonish [1].

  [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876905

However, until it gets removed from the archive and because still many packages
directly build-depend on it, it's a problem for new ports, because it blocks a
substantial part of the archive from being built.

I cannot recall all the packages right now, since I was working on this a few
weeks ago and had to stop for a bit, but it blocks many dozens or hundreds of
packages among direct and indirect packages, sometimes very remotely related to
this source package, but nevertheless affected.

We have this package in the suite "unreleased"; as long as there are no more
uploads, we're good.  But if there are new uploads with version >= 9.2, it can
break things for us.

So please consider including support for this architecture by applying the
attached patch if you upload new versions.

BTW, I think that we already submitted support for this upstream (or if not,
we'll do it over the next weeks), but I suspect that this package will not get
new upstream releases, so adding the patch directly is the only option in this
case.


Thanks and cheers.
--
Manuel A. Fernandez Montecelo <mafm@debian.org>

diff -Nru qtwebkit-2.3.4.dfsg/debian/changelog qtwebkit-2.3.4.dfsg/debian/changelog
--- qtwebkit-2.3.4.dfsg/debian/changelog	2016-11-23 11:46:11.000000000 +0100
+++ qtwebkit-2.3.4.dfsg/debian/changelog	2018-05-04 22:40:02.000000000 +0200
@@ -1,3 +1,10 @@
+qtwebkit (2.3.4.dfsg-9.1+0.riscv64.1) unreleased; urgency=medium
+
+  * Non-maintainer upload.
+  * riscv64: add support
+
+ -- Manuel A. Fernandez Montecelo <mafm@localhost>  Fri, 04 May 2018 20:40:02 +0000
+
 qtwebkit (2.3.4.dfsg-9.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru qtwebkit-2.3.4.dfsg/debian/patches/riscv64-support.patch qtwebkit-2.3.4.dfsg/debian/patches/riscv64-support.patch
--- qtwebkit-2.3.4.dfsg/debian/patches/riscv64-support.patch	1970-01-01 01:00:00.000000000 +0100
+++ qtwebkit-2.3.4.dfsg/debian/patches/riscv64-support.patch	2018-05-04 22:40:02.000000000 +0200
@@ -0,0 +1,47 @@
+Index: qtwebkit-2.3.4.dfsg/Source/WTF/wtf/Platform.h
+===================================================================
+--- qtwebkit-2.3.4.dfsg.orig/Source/WTF/wtf/Platform.h
++++ qtwebkit-2.3.4.dfsg/Source/WTF/wtf/Platform.h
+@@ -345,13 +345,20 @@
+ #endif
+ #endif
+ 
++/* CPU(RISCV64) - RISC-V 64 */
++#if defined(__riscv) && (__riscv_xlen == 64)
++#define WTF_CPU_RISCV64 1
++#define ENABLE_JIT 0
++#define ENABLE_YARR_JIT 0
++#endif
++
+ /* CPU(M68K) - m68k */
+ #if defined(__mc68000__)
+ #define WTF_CPU_M68K 1
+ #define WTF_CPU_BIG_ENDIAN 1
+ #endif
+ 
+-#if CPU(ARM) || CPU(MIPS) || CPU(SH4) || CPU(SPARC) || CPU(MIPS64)
++#if CPU(ARM) || CPU(MIPS) || CPU(SH4) || CPU(SPARC) || CPU(MIPS64) || CPU(RISCV64)
+ #define WTF_CPU_NEEDS_ALIGNED_ACCESS 1
+ #endif
+ 
+@@ -914,6 +921,7 @@
+     || CPU(SPARC64) \
+     || CPU(S390X) \
+     || CPU(AARCH64) \
++    || CPU(RISCV64) \
+     || CPU(MIPS64) \
+     || CPU(PPC64)
+ #define WTF_USE_JSVALUE64 1
+Index: qtwebkit-2.3.4.dfsg/Source/WTF/wtf/dtoa/utils.h
+===================================================================
+--- qtwebkit-2.3.4.dfsg.orig/Source/WTF/wtf/dtoa/utils.h
++++ qtwebkit-2.3.4.dfsg/Source/WTF/wtf/dtoa/utils.h
+@@ -49,7 +49,7 @@
+ defined(__ARMEL__) || \
+ defined(_MIPS_ARCH_MIPS32R2)
+ #define DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS 1
+-#elif CPU(MIPS) || CPU(PPC) || CPU(PPC64) || OS(WINCE) || CPU(SH4) || CPU(S390) || CPU(S390X) || CPU(IA64) || CPU(SPARC) || CPU(ALPHA) || CPU(MIPS64) || CPU(AARCH64) || CPU(HPPA)
++#elif CPU(MIPS) || CPU(PPC) || CPU(PPC64) || OS(WINCE) || CPU(SH4) || CPU(S390) || CPU(S390X) || CPU(IA64) || CPU(SPARC) || CPU(ALPHA) || CPU(MIPS64) || CPU(AARCH64) || CPU(HPPA) || CPU(RISCV64)
+ #define DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS 1
+ #elif defined(_M_IX86) || defined(__i386__)
+ #if defined(_WIN32)
diff -Nru qtwebkit-2.3.4.dfsg/debian/patches/series qtwebkit-2.3.4.dfsg/debian/patches/series
--- qtwebkit-2.3.4.dfsg/debian/patches/series	2016-11-17 22:20:52.000000000 +0100
+++ qtwebkit-2.3.4.dfsg/debian/patches/series	2018-05-04 22:34:46.000000000 +0200
@@ -26,3 +26,4 @@
 fix_x32_cpu_detection.patch
 disable-jit-nonsse2.patch
 m68k_support.diff
+riscv64-support.patch

--- End Message ---
--- Begin Message --- 
Source: qtwebkit
Source-Version: 2.3.4.dfsg-10

We believe that the bug you reported is fixed in the latest version of
qtwebkit, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 901566@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Lisandro Damián Nicanor Pérez Meyer <lisandro@debian.org> (supplier of updated qtwebkit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 20 Jun 2018 22:00:25 -0300
Source: qtwebkit
Binary: libqtwebkit-dev libqtwebkit4 libqtwebkit-qmlwebkitplugin libqtwebkit4-dbg
Architecture: source
Version: 2.3.4.dfsg-10
Distribution: unstable
Urgency: medium
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Lisandro Damián Nicanor Pérez Meyer <lisandro@debian.org>
Description:
 libqtwebkit-dev - Web content engine library for Qt - development files
 libqtwebkit-qmlwebkitplugin - Qt WebKit QML plugin
 libqtwebkit4 - Web content engine library for Qt
 libqtwebkit4-dbg - Web content engine library for Qt - debugging symbols
Closes: 879429 901566
Changes:
 qtwebkit (2.3.4.dfsg-10) unstable; urgency=medium
 .
   [ Dmitry Shachnev ]
   * Change section from libs to oldlibs.
 .
   [ Maximiliano Curia ]
   * Update uploaders list as requested by MIA team (Closes: #879429)
 .
   [ Manuel A. Fernandez Montecelo ]
   * Add riscv64-support.patch to support new arch riscv64 (Closes: #901566)
Checksums-Sha1:
 ef864663b2db7d81be5821eb052d9c4899a6a95e 2581 qtwebkit_2.3.4.dfsg-10.dsc
 5bf2f35e71add65357d7e7b541383559b6a443b8 86652 qtwebkit_2.3.4.dfsg-10.debian.tar.xz
 c0cdd3d38b8954272341762475ba18d263f1b790 7852 qtwebkit_2.3.4.dfsg-10_source.buildinfo
Checksums-Sha256:
 b0e97920c7392782062637a26bdec3085a4d74dffb6b469d485b3bfa4e207221 2581 qtwebkit_2.3.4.dfsg-10.dsc
 ade7b819407c49892577364e7038682602a2dac8b7a4d86d0383462807dd2670 86652 qtwebkit_2.3.4.dfsg-10.debian.tar.xz
 646a8a557961f878feebb94c7566a6e3da5b9e1dff6973e7a7b44d40343d7cc9 7852 qtwebkit_2.3.4.dfsg-10_source.buildinfo
Files:
 5496b52aa4f07859b5fdd7c8281eaca0 2581 oldlibs optional qtwebkit_2.3.4.dfsg-10.dsc
 d6c1a970dd2c12027c534cf9207820a4 86652 oldlibs optional qtwebkit_2.3.4.dfsg-10.debian.tar.xz
 a603d970851b0d0401199d5c9910309d 7852 oldlibs optional qtwebkit_2.3.4.dfsg-10_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCAAyFiEEEt36hKwjsrvwSzE8q2RfQGKGp9AFAlsq+jsUHGxpc2FuZHJv
QGRlYmlhbi5vcmcACgkQq2RfQGKGp9CEsBAAlqQB8ejBVJ2pVicmZF3WE92BNfNb
awQRJ2w11YzoN9Zb7pHWxX9dgwbNNjI98w8K9ANQtmumc4yiJ4mQUFJSPUeI4CqG
E7ByJInsucxF8k5XkVBUb5Zx2L788qdip+HKb/N+QHYJ5kSdVGwEYSGWiJ7mlPc/
7dys/b1z4mkchiHKWrql/MfNohyha9G6deecXYspIpP1kSxJt4YqEPPeckua8H9P
+yUFKpQeHOVla3ALo4yvXIrtnrUB8Uj4cnp37adhSWlnHdXQ8EEi6j7LBUOJD+qo
KTrY3W39gCiGY9laSzrSzdIuU/esy5oJYLPqYcJNqyPWj3cXchMGiprHSwJlCYcT
39ujH0PIoPnBVBWDh37PodUQvS2uF1fsFgOB1RbTIjBH/C0D/hFIuF4/qRy4rBkv
0QBXeozIroa+QD6VaLxGPmh6sWMJ4qOWJZa/6oa5weBkwjnCZv9eYE9h7j7pp5dk
rlaKAko2556wRhoqp/5Cswduo4YEzmh91LRYnyEXZibzSZOx7a0pdsqvFOSIXNnh
73pfXOxitL47gSqlsUqdGIRRDcZbq3Zf90nSEVzjRlMhgE54nguhhSPKlTUpnyY7
j2mcSIJxGEdo4ikUoGvNAqPUqf6zdRsmisplrUX3F+M+xkvxGDTdazhwMPCAMzNd
Z3gPwLR1dXTO9Ls=
=LAk0
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: