Control: affects -1 kwin-style-breeze Control: tags -1 patch Attached are patches for the Debian packaging. I've have tested them with both light and dark themes and can confirm that it closes this bug. Also, I've marked this bug as also affecting kwin-style-breeze because this patch has another very welcome effect! It fixes annoying behaviour where the active window title bar is lowlighted and all inactive windows are highlighted; I can imagine would be really annoying for people who do window management with a mouse rather than keyboard. Cheers, Nicholas
From 1a215d224f280e5ee374455d496296c9cb062993 Mon Sep 17 00:00:00 2001
From: Nicholas D Steeves <nsteeves@gmail.com>
Date: Tue, 4 Jul 2017 19:43:51 -0400
Subject: [PATCH 1/2] Import upstream patch that fixes highlighting of active
tab (Closes: #866996)
---
...e-Shadow-instead-of-QPalette-Text-to-dark.patch | 22 ++++++++++++++++++++++
debian/patches/series | 1 +
2 files changed, 23 insertions(+)
create mode 100644 debian/patches/0001-Use-QPalette-Shadow-instead-of-QPalette-Text-to-dark.patch
create mode 100644 debian/patches/series
diff --git a/debian/patches/0001-Use-QPalette-Shadow-instead-of-QPalette-Text-to-dark.patch b/debian/patches/0001-Use-QPalette-Shadow-instead-of-QPalette-Text-to-dark.patch
new file mode 100644
index 0000000..3dc2ce6
--- /dev/null
+++ b/debian/patches/0001-Use-QPalette-Shadow-instead-of-QPalette-Text-to-dark.patch
@@ -0,0 +1,22 @@
+From: Hugo Pereira Da Costa <hugo.pereira.da.costa@gmail.com>
+Date: Tue, 21 Feb 2017 10:30:18 +0100
+Subject: Use QPalette::Shadow instead of QPalette::Text to darken inactive
+ tabs BUG:373088
+
+---
+ kstyle/breezestyle.cpp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/kstyle/breezestyle.cpp b/kstyle/breezestyle.cpp
+index d3f6d46..b687c3f 100644
+--- a/kstyle/breezestyle.cpp
++++ b/kstyle/breezestyle.cpp
+@@ -5549,7 +5549,7 @@ namespace Breeze
+
+ } else {
+
+- const QColor normal( _helper->alphaColor( palette.color( QPalette::WindowText ), 0.2 ) );
++ const QColor normal( _helper->alphaColor( palette.color( QPalette::Shadow ), 0.2 ) );
+ const QColor hover( _helper->alphaColor( _helper->hoverColor( palette ), 0.2 ) );
+ if( animated ) color = KColorUtils::mix( normal, hover, opacity );
+ else if( mouseOver ) color = hover;
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..0d04457
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+0001-Use-QPalette-Shadow-instead-of-QPalette-Text-to-dark.patch
--
2.11.0
From a773e69bd8fd98595d99e354739fe65ef3c7a69f Mon Sep 17 00:00:00 2001 From: Nicholas D Steeves <nsteeves@gmail.com> Date: Tue, 4 Jul 2017 19:45:42 -0400 Subject: [PATCH 2/2] Update changelog --- debian/changelog | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/debian/changelog b/debian/changelog index a0df2f7..5885074 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,11 @@ +breeze (4:5.8.5-2+debu9u1) UNRELEASED; urgency=medium + + [ Nicholas D Steeves ] + * Import upstream patch that fixes highlighting of active tab. (Closes: + #866996) + + -- Nicholas D Steeves <nsteeves@gmail.com> Tue, 04 Jul 2017 19:44:41 -0400 + breeze (4:5.8.5-2) unstable; urgency=medium * Release to unstable. -- 2.11.0
Attachment:
signature.asc
Description: Digital signature