[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#839283: marked as done (qimageblitz FTCBFS: uses the build architecture compiler and detects build architecture capabilities)

Your message dated Mon, 26 Jun 2017 18:18:52 +0000
with message-id <E1dPYb6-0009Ci-US@fasolo.debian.org>
and subject line Bug#839283: fixed in qimageblitz 1:0.0.6-5
has caused the Debian Bug report #839283,
regarding qimageblitz FTCBFS: uses the build architecture compiler and detects build architecture capabilities
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
839283: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=839283
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: qimageblitz
Version: 1:0.0.6-4
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

qimageblitz fails to cross build from source, because it compiles its
assembly file with the build architecture compiler and then fails
linking it. It uses plain gcc instead of the proper cmake variable
${CMAKE_C_COMPILER} there. It also determines whether to use certain
processor features (e.g. MMX) by looking at the architecture one is
building on (build architecture) instead of the architecture one is
building for (host architecture). The attached patch fixes both problems
and makes qimageblitz cross build just fine. Please consider applying
it.

Helmut

diff --minimal -Nru qimageblitz-0.0.6/debian/changelog qimageblitz-0.0.6/debian/changelog
--- qimageblitz-0.0.6/debian/changelog	2011-06-23 10:26:57.000000000 +0200
+++ qimageblitz-0.0.6/debian/changelog	2016-09-30 22:30:15.000000000 +0200
@@ -1,3 +1,12 @@
+qimageblitz (1:0.0.6-4.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Use CMAKE_C_COMPILER instead of gcc
+    + Fix build/host confusion
+
+ -- Helmut Grohne <helmut@subdivi.de>  Fri, 30 Sep 2016 22:29:29 +0200
+
 qimageblitz (1:0.0.6-4) unstable; urgency=low
 
   * Replace $(overriden_command) with $(overridden_command) in debian/rules.
diff --minimal -Nru qimageblitz-0.0.6/debian/patches/14_cross.diff qimageblitz-0.0.6/debian/patches/14_cross.diff
--- qimageblitz-0.0.6/debian/patches/14_cross.diff	1970-01-01 01:00:00.000000000 +0100
+++ qimageblitz-0.0.6/debian/patches/14_cross.diff	2016-09-30 22:29:09.000000000 +0200
@@ -0,0 +1,16 @@
+From: Helmut Grohne <helmut@subdivi.de>
+Subject: use the host architecture compiler
+
+Index: qimageblitz-0.0.6/blitz/CMakeLists.txt
+===================================================================
+--- qimageblitz-0.0.6.orig/blitz/CMakeLists.txt
++++ qimageblitz-0.0.6/blitz/CMakeLists.txt
+@@ -33,7 +33,7 @@
+     if(NOT APPLE AND NOT WIN32)
+         set( blitz_LIB_SRCS ${blitz_LIB_SRCS} asm_scale.S )
+         add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/asm_scale.o
+-            COMMAND gcc -c ${CMAKE_CURRENT_SOURCE_DIR}/asm_scale.S
++            COMMAND ${CMAKE_C_COMPILER} -c ${CMAKE_CURRENT_SOURCE_DIR}/asm_scale.S
+             DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/asm_scale.S )
+         set( blitz_LIB_EXTRA_SRCS ${CMAKE_CURRENT_BINARY_DIR}/asm_scale.o )
+         set(HAVE_EXTERNAL_ASM TRUE)
diff --minimal -Nru qimageblitz-0.0.6/debian/patches/series qimageblitz-0.0.6/debian/patches/series
--- qimageblitz-0.0.6/debian/patches/series	2010-09-19 11:38:11.000000000 +0200
+++ qimageblitz-0.0.6/debian/patches/series	2016-09-30 22:26:49.000000000 +0200
@@ -2,3 +2,4 @@
 11_.gnu.note.diff
 12_remove_FindQt4.cmake.diff
 13_disable_usr_lib_rpath.diff
+14_cross.diff
diff --minimal -Nru qimageblitz-0.0.6/debian/rules qimageblitz-0.0.6/debian/rules
--- qimageblitz-0.0.6/debian/rules	2011-04-27 14:37:40.000000000 +0200
+++ qimageblitz-0.0.6/debian/rules	2016-09-30 22:29:27.000000000 +0200
@@ -8,7 +8,7 @@
 cpu_opt_amd64 = 3dnow mmx sse sse2 sse3
 cpu_opt_powerpc = altivec
 
-build_arch_opts = $(cpu_opt_$(shell dpkg-architecture -qDEB_BUILD_ARCH_CPU))
+build_arch_opts = $(cpu_opt_$(shell dpkg-architecture -qDEB_HOST_ARCH_CPU))
 
 ifneq (,$(build_arch_opts))

--- End Message ---
--- Begin Message --- 
Source: qimageblitz
Source-Version: 1:0.0.6-5

We believe that the bug you reported is fixed in the latest version of
qimageblitz, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 839283@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Pino Toscano <pino@debian.org> (supplier of updated qimageblitz package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 26 Jun 2017 19:55:31 +0200
Source: qimageblitz
Binary: libqimageblitz4 libqimageblitz-dev
Architecture: source
Version: 1:0.0.6-5
Distribution: unstable
Urgency: medium
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Pino Toscano <pino@debian.org>
Description:
 libqimageblitz-dev - development files for the QImageBlitz image effects library
 libqimageblitz4 - QImageBlitz image effects library
Closes: 839283
Changes:
 qimageblitz (1:0.0.6-5) unstable; urgency=medium
 .
   * Team upload.
 .
   [ Maximiliano Curia ]
   * Bump debhelper compat and build dep to 9.
   * Bump Standards-Version to 3.9.6, no changes needed.
 .
   [ Pino Toscano ]
   * Update Vcs-* fields.
   * Backport upstream r1203426 to use the proper C compiler when building
     assembler sources; patch r1203426.diff.
   * Backport upstream r1286623 to fix build with newer/different C++
     compilers; patch r1286623.diff.
   * Remove libqimageblitz-dbg in favour of the -dbgsym packages.
   * Bump Standards-Version to 4.0.0, no changes required.
 .
   [ Helmut Grohne ]
   * Fix build/host confusion in rules. (Closes: #839283)
Checksums-Sha1:
 d11a68b75bbd8afa0b858a7bd540f7f78d1020b7 2111 qimageblitz_0.0.6-5.dsc
 842bd7ec64540550291076d50f06e29bfed86657 18380 qimageblitz_0.0.6-5.debian.tar.xz
 dd6b30e1c2634993ae90765baa8947ae81368cda 8280 qimageblitz_0.0.6-5_source.buildinfo
Checksums-Sha256:
 a4acd81457e958e89043fad7180b20c6327fc872c5868bacec687bc62cceae02 2111 qimageblitz_0.0.6-5.dsc
 14f5f2e0bb18182c7719f8546ec61f2cea50997689dccd885f97ad17afc767a1 18380 qimageblitz_0.0.6-5.debian.tar.xz
 8ac1cac8cdd2a832d8891c45b71156d705b7616b25178a245f5e6363d391faee 8280 qimageblitz_0.0.6-5_source.buildinfo
Files:
 6804999b416a1f782acc5d8e5bd9360c 2111 libs optional qimageblitz_0.0.6-5.dsc
 4615c5111cf4aff0826a0318467a4136 18380 libs optional qimageblitz_0.0.6-5.debian.tar.xz
 3b0f1288ed5e5fa04b4efcb7c347cced 8280 libs optional qimageblitz_0.0.6-5_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEXyqfuC+mweEHcAcHLRkciEOxP00FAllRSu4ACgkQLRkciEOx
P02hag//d6tlD5NnRbaL6e3Bo/hnNYsfGoHnuS6tEhLeCJ/PFsDji/ZlBkmP0O8L
EpedDCfl9P5NS/AISlHAR0+jnHKpOUevcH3csLKtVI1O88Bna0ikmkIjS9g1t8bg
j3CdpGZn8/sUiWkAhrAOLSzPbt7Xpmwah5wVf5w2yGK9oCk8NMP5wgJ9aPbDpg5G
TnugyMEXfM3LFhCsEyV/J4zg/iHBjx8NVzOV+0wSPphpUSNg/SSwJnRh6lP/H9nv
nfXAfscTc88CTpginmMayanYdQIMt3Y2w4P6ebdlV2PnRCqubCe4GyVaoiqOq+Oc
Hq2K2tk//h3CqLnHUssaUMzJyDdNjVZXvOixivNKFpkgU3WiDKJsJU3jlJMX603F
tUdMBC6t0RhQXRLQQD3uO5O40xIqg2MEZdBEb1EbNPXMNwEb0zwcLXm/lvuxDfFi
CkVfHLkv9OOwA6jbp4lmVvVNe9pSl4+YHUO28nm5SC/QXxGqdwFazXuyF5TDgqQq
4lUPp+0aV2S2VxJybOPK4rO/QfqqNe9HcUqAiVQJcXUVg9RuNYWT6fVLVoWNU4Vl
iXn+E17/Vlhz7z6vF0E0ffgUHteH/QThbvY2g3eeLNjtCz2IAxuIKHSFaoSedZp5
uEYPIIXtZSSZAs48lx51PKxkNYsaX/o2+Y7jtv0wtUTzELSwOZc=
=f+GS
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: