[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#858584: marked as done (konsole: please backport font rendering fix for noto-sans)



Your message dated Mon, 27 Mar 2017 12:48:45 +0000
with message-id <E1csU4j-000DQ7-ON@fasolo.debian.org>
and subject line Bug#858584: fixed in konsole 4:16.12.0-2
has caused the Debian Bug report #858584,
regarding konsole: please backport font rendering fix for noto-sans
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
858584: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=858584
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: konsole
Version: 4:16.12.0-1
Severity: normal
Tags: patch

Font rendering for Noto Sans CJK in konsole has long been broken. This made
users of konsole + Noto Sans CJK painful.

Upstream committed a fix in git HEAD recently:

    https://git.reviewboard.kde.org/r/129281/diff/2/

It would be great if konsole in Stretch would include this fix.

A raw diff file will be sent as well as attachment.



-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=zh_CN.UTF-8, LC_CTYPE=zh_CN.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages konsole depends on:
ii  kio                   5.28.0-1
ii  konsole-kpart         4:16.12.0-1
ii  libc6                 2.24-9
ii  libkf5completion5     5.28.0-1
ii  libkf5configcore5     5.28.0-1+b2
ii  libkf5configgui5      5.28.0-1+b2
ii  libkf5configwidgets5  5.28.0-1
ii  libkf5coreaddons5     5.28.0-1+b2
ii  libkf5crash5          5.28.0-1
ii  libkf5dbusaddons5     5.28.0-1
ii  libkf5i18n5           5.28.0-1+b2
ii  libkf5iconthemes5     5.28.0-1
ii  libkf5kiowidgets5     5.28.0-1
ii  libkf5notifyconfig5   5.28.0-1
ii  libkf5widgetsaddons5  5.28.0-1
ii  libkf5windowsystem5   5.28.0-1
ii  libkf5xmlgui5         5.28.0-1
ii  libqt5core5a          5.7.1+dfsg-3+b1
ii  libqt5gui5            5.7.1+dfsg-3+b1
ii  libqt5widgets5        5.7.1+dfsg-3+b1
ii  libstdc++6            6.3.0-6

konsole recommends no packages.

konsole suggests no packages.

-- no debconf information
diff --git a/src/TerminalDisplay.cpp b/src/TerminalDisplay.cpp
index 39a8b84..dc991ef 100644
--- a/src/TerminalDisplay.cpp
+++ b/src/TerminalDisplay.cpp
@@ -856,18 +856,10 @@ void TerminalDisplay::drawCharacters(QPainter& painter,
         // This still allows RTL characters to be rendered in the RTL way.
         painter.setLayoutDirection(Qt::LeftToRight);
 
-        // the drawText(rect,flags,string) overload is used here with null flags
-        // instead of drawText(rect,string) because the (rect,string) overload causes
-        // the application's default layout direction to be used instead of
-        // the widget-specific layout direction, which should always be
-        // Qt::LeftToRight for this widget
-        //
-        // This was discussed in: http://lists.kde.org/?t=120552223600002&r=1&w=2
         if (_bidiEnabled) {
-            painter.drawText(rect, 0, text);
+            painter.drawText(rect.x(), rect.y() + QFontMetrics(font).ascent(), text);
         } else {
-            // See bug 280896 for more info
-            painter.drawText(rect, Qt::AlignBottom, LTR_OVERRIDE_CHAR + text);
+            painter.drawText(rect.x(), rect.y() + QFontMetrics(font).ascent(), LTR_OVERRIDE_CHAR + text);
         }
     }
 }

--- End Message ---
--- Begin Message ---
Source: konsole
Source-Version: 4:16.12.0-2

We believe that the bug you reported is fixed in the latest version of
konsole, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 858584@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Maximiliano Curia <maxy@debian.org> (supplier of updated konsole package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 27 Mar 2017 14:17:37 +0200
Source: konsole
Binary: konsole konsole-kpart
Architecture: source
Version: 4:16.12.0-2
Distribution: experimental
Urgency: medium
Maintainer: Debian/Kubuntu Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Maximiliano Curia <maxy@debian.org>
Description:
 konsole    - X terminal emulator
 konsole-kpart - Konsole plugin for Qt applications
Closes: 858584
Changes:
 konsole (4:16.12.0-2) experimental; urgency=medium
 .
   * Add new upstream patch:
     upstream_render_text_at_primary_fonts_baseline.patch (Closes: 858584)
   * Add upstream patch: Add-nofork-as-compatibility-alias-for-separate.patch
   * Add upstream patch: Fix-build.patch
   * Add upstream patch: TerminalDisplay-Abort-painting-invalid-rect.patch
   * Add upstream patch:
     Screen-Fix-potential-crash-when-ExtendedCharTable-tries-t.patch
   * Add upstream patch: Handle-surrogate-utf16-characters.patch
   * Add upstream patch: Fix-word-boundaries-with-combining-characters.patch
   * Add upstream patch:
     Don-t-include-newlines-in-selection-if-trimming-is-on.patch
   * Add upstream patch: Limit-ourselves-to-3-combining-characters.patch
   * Add upstream patch: Allow-ANSI-string-terminator-to-work.patch
   * Add upstream patch: Fix-opening-of-new-tabs-with-multiple-processes.patch
Checksums-Sha1:
 daef06396ec50b20be9529a0fd9349e272b89262 3095 konsole_16.12.0-2.dsc
 87a9131725fc748f8b3afc339252759629f4d287 16800 konsole_16.12.0-2.debian.tar.xz
 c3a211e50ae3121080506260866c07b6009ad4c4 21880 konsole_16.12.0-2_source.buildinfo
Checksums-Sha256:
 b461c36f67417a99660576012d83998183321f2f831ff05a894392271da200a7 3095 konsole_16.12.0-2.dsc
 0ff0273fb60a35cd9550c9eae645002b7e5cdfd740d190dfc75c9ad5209c5a95 16800 konsole_16.12.0-2.debian.tar.xz
 4121f347b580a50196fc4c2d3be08a58342bd204aa6699144f07c288ba36bd30 21880 konsole_16.12.0-2_source.buildinfo
Files:
 eb7aeb066f7ec1b1cffdea2fd12a5fb8 3095 kde optional konsole_16.12.0-2.dsc
 01cc6e4062b51a68a7fab8054643ec5b 16800 kde optional konsole_16.12.0-2.debian.tar.xz
 476b0fcc19a709305deb8d899d3adbde 21880 kde optional konsole_16.12.0-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE+JIdOnQEyG4RNSIVxxl2mbKbIyoFAljZBhgACgkQxxl2mbKb
IypOBxAAnDMiHDeu2lYVA+2ISFD5WYUlAy04NKL9ef1YTN48CJVRJpSLJy0VHzXr
F1LY5NG0pEIUkqdtQIlMVCVpcljLFRh4DqbZGjUo2B0Jk1Q3TZDSC3EvTsTtBHzZ
WM7sR5+dd1ZheSqrfeOxoQpley0QcsRfdXkpzgMPcvHN3q46a+tRZro/pBMFZZnP
bvEJ2Srghy8egiO+o8e1a2XWSLyH1XELH4MR3bUtfych66qxLcWY/m9o+xD0NgG9
XE8kow1a06esm1J70SwzGF6/DANvH64mlCFBc5lp4JHbMTpxATlSe5P+gAyffSGH
bvYvWADkJgb2Zdd3GUmiJOd1UJ6cLqGGOgmfVlMT38Au77+nuG7inTqNhKNE4VIw
dUD8MLMxb55po0gzbVuuK4W7lqe4CewTwlTm6qVhygIBVMwf6xBVVpdQ1if1Ubcj
4Kz1aLltifTnXXcv2r/5avokL1zFiNWgZ4n7MGxslXDLqPDx/EKfOnDWJABp0Dcs
A/VN5Epg4A4VY3NX+k7YSWM27SCB5L6bXpi6bpbnnYgZmJy0BMAfdGo8dRHc51SL
BIqk848x6sl6u1WJDWeZjmJ83vlpuWJL8Ip6QLzP02wsDU27pUycbZB5SlfgXPpS
kntI1TV957PzCWoXXoc+OyNAGjWPfvKmbLCTV0yfMbx204dnnNs=
=P2pw
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: