Bug#850114: kscd: Only play first trackon all modes(loop track, loop ,and no loop and random and no random mode)
Control: tags -1 patch
Hi!
The attached debdiff contains a patch which fixes the issue.
It turns out that someone, for whatever reasons, had hard-coded the disc ID to
"64e.YDM.N2tZJzmqrN48iWfJ9.4-" [1] which is the ID for Nirvana's "Smells Like
Teen Spirit" album. Just reverting the patch fixes the issue for me and audio
CDs are detected properly again.
Thanks,
Adrian
> [1] http://sources.debian.net/src/kscd/4:16.08.1-1/mbmanager.cpp/#L219
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
diff -Nru kscd-16.08.1/debian/changelog kscd-16.08.1/debian/changelog
--- kscd-16.08.1/debian/changelog 2016-10-18 23:59:43.000000000 +0200
+++ kscd-16.08.1/debian/changelog 2017-03-06 20:10:04.000000000 +0100
@@ -1,3 +1,11 @@
+kscd (4:16.08.1-1.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Remove hard-coded disc ID in disc lookup code. (Closes: #850114)
+ - New patch: remove_hard-coded_disc_ID.diff
+
+ -- John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Mon, 06 Mar 2017 20:10:04 +0100
+
kscd (4:16.08.1-1) unstable; urgency=medium
[ Automatic packaging ]
diff -Nru kscd-16.08.1/debian/patches/remove_hard-coded_disc_ID.diff kscd-16.08.1/debian/patches/remove_hard-coded_disc_ID.diff
--- kscd-16.08.1/debian/patches/remove_hard-coded_disc_ID.diff 1970-01-01 01:00:00.000000000 +0100
+++ kscd-16.08.1/debian/patches/remove_hard-coded_disc_ID.diff 2017-03-06 19:50:15.000000000 +0100
@@ -0,0 +1,16 @@
+Description: Drop hard-coded disc ID in MBManager
+Author: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
+Last-Update: 2017-03-06
+
+--- kscd-16.08.1.orig/mbmanager.cpp
++++ kscd-16.08.1/mbmanager.cpp
+@@ -216,8 +216,7 @@ void MBManager::discLookup(const QString
+
+ int discid_ok = discid_read_sparse(m_discid, qPrintable(device), 0);
+ if (discid_ok) {
+- //std::string discId(discid_get_id(m_discid));
+- std::string discId("64e.YDM.N2tZJzmqrN48iWfJ9.4-");
++ std::string discId(discid_get_id(m_discid));
+ try
+ {
+ MusicBrainz5::CMetadata metadata, fullMetadata;
diff -Nru kscd-16.08.1/debian/patches/series kscd-16.08.1/debian/patches/series
--- kscd-16.08.1/debian/patches/series 2016-10-18 23:59:43.000000000 +0200
+++ kscd-16.08.1/debian/patches/series 2017-03-06 20:06:53.000000000 +0100
@@ -1,2 +1,3 @@
migrate_to_musicbrainz5.diff
test_args_as_const.diff
+remove_hard-coded_disc_ID.diff
Reply to: