Bug#856904: ksirk FTBFS on architectures where char is unsigned
Control: tags -1 patch
Hi!
The attached debdiff contains a trivial patch which changes the declaration
of tbl[] from "char" to "signed char". With the patch applied, I verified
that the package builds successfully on armhf.
Thanks,
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
diff -Nru ksirk-16.04.0/debian/changelog ksirk-16.04.0/debian/changelog
--- ksirk-16.04.0/debian/changelog 2016-05-21 23:36:29.000000000 +0200
+++ ksirk-16.04.0/debian/changelog 2017-03-06 10:44:11.000000000 +0100
@@ -1,3 +1,11 @@
+ksirk (4:16.04.0-1.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Add patch: fix-signage-of-tbl-array.diff to fix FTBFS on
+ architectures where 'char' is unsigned. (Closes: #856904)
+
+ -- John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Mon, 06 Mar 2017 10:44:11 +0100
+
ksirk (4:16.04.0-1) unstable; urgency=medium
[ Automatic packaging ]
diff -Nru ksirk-16.04.0/debian/patches/fix-signage-of-tbl-array.diff ksirk-16.04.0/debian/patches/fix-signage-of-tbl-array.diff
--- ksirk-16.04.0/debian/patches/fix-signage-of-tbl-array.diff 1970-01-01 01:00:00.000000000 +0100
+++ ksirk-16.04.0/debian/patches/fix-signage-of-tbl-array.diff 2017-03-06 10:41:34.000000000 +0100
@@ -0,0 +1,15 @@
+Description: Fix signage of tbl array in XMPP code
+Author: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
+Last-Update: 2017-03-06
+
+--- ksirk-16.04.0.orig/ksirk/iris/src/xmpp/base64/base64.cpp
++++ ksirk-16.04.0/ksirk/iris/src/xmpp/base64/base64.cpp
+@@ -45,7 +45,7 @@ QByteArray Base64::decode(const QString&
+ // 64 specifies eof
+ // everything else specifies data
+
+- char tbl[] = {
++ signed char tbl[] = {
+ -1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,
+ -1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,
+ -1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,62,-1,-1,-1,63,
diff -Nru ksirk-16.04.0/debian/patches/series ksirk-16.04.0/debian/patches/series
--- ksirk-16.04.0/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ ksirk-16.04.0/debian/patches/series 2017-03-06 10:44:09.000000000 +0100
@@ -0,0 +1 @@
+fix-signage-of-tbl-array.diff
Reply to: