[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#854260: sddm: Please remove Conflicts= and OnFailure= from sddm.service file



Source: sddm
Version: 0.13.0-1
Severity: normal

Hi,

The debian/sddm.service file contains the following lines:

Conflicts=plymouth-quit-wait.service
After=systemd-user-sessions.service plymouth-start.service plymouth-quit-wait.service
OnFailure=plymouth-quit.service

For me the Conflicts= (and the OnFailure=) doesn't make any sense. The
gdm.service file contains these line too but only because GDM takes care
himself of stopping plymouth. sddm should just wait that plymouth
is stopped here and nothing else.

The OnFailure= is also redundant here if the Conflicts= is removed as
the plymouth-quit.service will be executed anyway.

Upstream ships a file in services/sddm.service.in, with
After=plymouth-quit.service (like GDM), any reason you have modified
this?

Regards,

Laurent Bigonville

-- System Information:
Debian Release: 9.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)


Reply to: