[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#792594: libqt5qml5 requires SSE2 on i386



On domingo, 1 de enero de 2017 04:13:41 ART Guillem Jover wrote:
[snip]
> > I've found that the changes required for each minor version are rather
> > minimal.
> 
> This still is the case up to now. Well, with latest patches, the changes
> required were even more trivial.

Accroding to the diff this is indeed true.

> > In any case, because I need a patched Qt on my systems to be
> > able to run many Qt applications at all, I'll have to rebase the patches
> > and build local packages anyway. I'll try to send the rebased patches
> > here for whoever else needs them, if I remember.
> 
> As I had to upgrade all the systems involved, I needed to update
> the patches, which I did against 5.7.x and 5.8.x (git HEAD).
> 
> > If someone else wants access to the Qt Declaratives packages I'm
> > building please say so, and I'll publish them on some repository.
> 
> This still stands.

And you are really willing to take care of this delta, so let's make it 
official.

The only thing I would like you to change in order to accept the patch is to 
change the generic hasRequiredCpuSupport() for something more precise, maybe 
something along cpuHasSse2Support() or alike. Yes, I know it's just details, 
but helps while looking at the code.

Happy new year, Lisandro.

-- 
Yo quiero conocer el pensamiento de Dios, el resto son detalles.
 Albert Einstein

Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: